Skip to content

array tree layouts - #8066

Open
onursatici wants to merge 2 commits into
os/array-serialise-columnarfrom
os/array-tree-layout-stacked
Open

array tree layouts#8066
onursatici wants to merge 2 commits into
os/array-serialise-columnarfrom
os/array-tree-layout-stacked

Conversation

@onursatici

Copy link
Copy Markdown
Contributor

Summary

Adds two new layouts, array tree layout and array tree flat layout. Latter writes the array node into a vortex array instead of serialising it into a flatbuffer, and the former collects all these columnar array nodes and creates one segment from them and writes at the end of the file, before the zone maps.

This replaces inlining the array nodes as flatbuffers to the footer

@onursatici onursatici mentioned this pull request May 22, 2026
@codspeed-hq

codspeed-hq Bot commented May 22, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 19.91%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 5 regressed benchmarks
✅ 1540 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 20.4 µs 35.3 µs -42.15%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 177.2 µs 213.3 µs -16.94%
Simulation bitwise_not_vortex_buffer_mut[128] 186.1 ns 215.3 ns -13.55%
Simulation chunked_varbinview_canonical_into[(100, 100)] 273.8 µs 308.6 µs -11.3%
Simulation bitwise_not_vortex_buffer_mut[1024] 246.4 ns 275.6 ns -10.58%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing os/array-tree-layout-stacked (7c9a72b) with os/array-serialise-columnar (eb11f18)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@onursatici onursatici added the action/benchmark Trigger full benchmarks to run on this PR label May 27, 2026
@onursatici
onursatici force-pushed the os/array-serialise-columnar branch from 93e517d to 3257531 Compare May 28, 2026 14:16
@onursatici
onursatici force-pushed the os/array-tree-layout-stacked branch from 39bfedf to 1a052bd Compare May 28, 2026 14:21
@onursatici
onursatici force-pushed the os/array-serialise-columnar branch from 3257531 to 3c34669 Compare June 2, 2026 13:12
@onursatici
onursatici force-pushed the os/array-tree-layout-stacked branch from 1a052bd to 4636e34 Compare June 2, 2026 13:12
@onursatici
onursatici force-pushed the os/array-serialise-columnar branch 2 times, most recently from c33a177 to e40b94f Compare June 2, 2026 13:57
@onursatici
onursatici force-pushed the os/array-tree-layout-stacked branch 2 times, most recently from 744833b to 9f963b1 Compare June 9, 2026 09:45
@onursatici
onursatici force-pushed the os/array-serialise-columnar branch from e40b94f to 5739636 Compare June 15, 2026 15:41
@onursatici
onursatici force-pushed the os/array-tree-layout-stacked branch from 9f963b1 to d4dc062 Compare June 15, 2026 15:41
@onursatici
onursatici force-pushed the os/array-serialise-columnar branch from 5739636 to eb11f18 Compare June 16, 2026 10:41
Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Onur Satici <onur@spiraldb.com>
@onursatici
onursatici force-pushed the os/array-tree-layout-stacked branch from d4dc062 to 7c9a72b Compare June 16, 2026 11:09
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Jul 1, 2026
@robert3005 robert3005 removed the stale This PR is stale and will be auto-closed soon label Jul 1, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Jul 16, 2026
@robert3005 robert3005 removed the stale This PR is stale and will be auto-closed soon label Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action/benchmark Trigger full benchmarks to run on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants