Skip to content

Improve intersect_by_rank performance#7744

Draft
robert3005 wants to merge 2 commits intodevelopfrom
rk/intersect-by-rank
Draft

Improve intersect_by_rank performance#7744
robert3005 wants to merge 2 commits intodevelopfrom
rk/intersect-by-rank

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

We never spent time and this is useful for merging selections and filters in
scans

Signed-off-by: Robert Kruszewski github@robertk.io

@robert3005
Copy link
Copy Markdown
Contributor Author

I will go over this tomorrow @joseph-isaacs I looked at #7098 and #7393 which both optimised slightly different cases of this function. I tried to combine the two.

@robert3005 robert3005 added the changelog/performance A performance improvement label May 1, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 1, 2026

Merging this PR will degrade performance by 10.6%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 1 regressed benchmark
✅ 1179 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 246.1 ns 275.3 ns -10.6%

Comparing rk/intersect-by-rank (89f58dc) with develop (a9dc3a2)

Open in CodSpeed

@robert3005 robert3005 force-pushed the rk/intersect-by-rank branch 2 times, most recently from 677cf42 to 8696808 Compare May 5, 2026 20:00
robert3005 added 2 commits May 5, 2026 22:27
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 force-pushed the rk/intersect-by-rank branch from 8696808 to 89f58dc Compare May 5, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant