propagate DUCKDB_SOURCE_DIR to Vortex - #90
Merged
Merged
Conversation
myrrc
enabled auto-merge (squash)
June 11, 2026 10:51
0ax1
approved these changes
Jun 11, 2026
0ax1
left a comment
0ax1
left a comment
Contributor
There was a problem hiding this comment.
Still needs the changes on the Vortex side but can land this part already.
0ax1
disabled auto-merge
June 11, 2026 11:02
myrrc
force-pushed
the
myrrc/duckdb-source-dir
branch
from
June 11, 2026 14:57
5377fcd to
dde5ad7
Compare
Contributor
Author
|
Ok, now time for a Vortex release, re-update here, and we can merge |
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
myrrc
force-pushed
the
myrrc/duckdb-source-dir
branch
from
June 12, 2026 15:43
27fa8e9 to
0ed81f7
Compare
myrrc
enabled auto-merge (squash)
June 12, 2026 15:52
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com> (cherry picked from commit 275ac23)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to skip duckdb download if we're building
in duckdb-vortex