Bugfix & Enhancement of fasta2select - #167
Open
gph82 wants to merge 2 commits into
Open
Conversation
…aracter between first and second sequence (old was checking 2nd vs 2nd)
…apless-sequences. Old: if gap char was "" (=None) and "-" the method would error out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugfix & Enhancement of structure.superposition.sequences.fasta2select
The bug was not actually detecting gap-less sequences. Even if corrected, gap-less sequences would error out, now they are handled properly.
The idea is to be minimally invasive wrt to existing logic for mapping pairwise alignments to residue selections.
Prospectively, logic behind this mapping could be re-written