Conversation
AndreaVolkamer
left a comment
AndreaVolkamer
left a comment
Member
There was a problem hiding this comment.
@AAriam thanks for looking into this. just wondering why all tests still fail?
Collaborator
Author
|
@AndreaVolkamer Before this PR the CI was failing due to outdated actions and workflow configurations, so the tests were not even executed. To keep commits clear, this PR only addresses those issues in the CI workflow. Now the workflow runs, but fails due to other reasons, namely outdated dependencies in OpenCADD and problems in the superposition subpackage. Some of these issues are addressed in #157. So the idea is that we squash-merge this PR into main, then update #157 from main. If you approve the PR I can do the rest. |
AndreaVolkamer
self-requested a review
April 16, 2025 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a minor update to the CI workflow to make it run again with the current configurations. Ready to merge into main.