docs(capacity): document ancestor reclaim level#530
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for hierarchical queues in Volcano (both current and versioned docs) to explain the configuration and behavior of the ancestorReclaimLevel parameter. It includes detailed scenarios and Mermaid diagrams to illustrate how different levels affect resource reclamation. The review feedback suggests a minor improvement to replace the non-standard term 'non-used' with 'unused' for better readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
994880a to
5969a87
Compare
Explain the capacity plugin ancestorReclaimLevel setting in the Hierarchical Queue guide, including configuration and concrete pod reclaim scenarios with queue-tree diagrams. Signed-off-by: Hajnal Máté <hajnalmt@gmail.com>
5969a87 to
9bb0bc5
Compare
| In this example, `queue-b` is over its own `deserved` resources and its parent `parent-b` is also over its `deserved` resources. `queue-a` has a pending pod that cannot be scheduled without reclaim. | ||
|
|
||
| ```mermaid | ||
| graph TD |
There was a problem hiding this comment.
Seems that mermaid didn't be rendered in the netlify preview page, could you check it mate?
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
/kind documentation
What this PR does / why we need it:
Documents the capacity plugin
ancestorReclaimLevelargument in the Hierarchical Queue guide.The update keeps the base scheduler configuration focused on enabling hierarchical queues, adds
ancestorReclaimLevelonly in the dedicated “Configure Ancestor Reclaim Scope” section, and places the detailed “UnderstandingancestorReclaimLevel” explanation after “Building Hierarchical Queues”. It also adds concrete queue and pod reclaim scenarios with Mermaid diagrams, including explicita100=1requests for the running pods in the A100 examples.AI assistance was used for drafting and local verification. The final wording and structure needed substantial human steering and review; hajnalmt had to hammer the assistant quite a lot to keep the placement, semantics, and examples aligned with the intended documentation change.
Fixes Document capacity plugin ancestorReclaimLevel #529
Related: volcano-sh/volcano#5115