fix: align install manifest with published vc-dashboard image#297
fix: align install manifest with published vc-dashboard image#297Pragati5-DEBUG wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request renames the Docker image from volcanosh/volcano-dashboard to volcanosh/vc-dashboard across the documentation, deployment manifests, and helper scripts. The review feedback points out that the updated sed pattern in the version-bumping script no longer supports optional image suffixes (such as -frontend), which contradicts the script's documentation. A code suggestion is provided to restore support for optional suffixes in the regular expression.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # Match image name volcanosh/vc-dashboard, then :tag | ||
| sed -i.bak "s|\(volcanosh/vc-dashboard:\)[^[:space:]]*|\1${NEW_TAG}|g" "${f}" |
There was a problem hiding this comment.
The updated sed pattern only matches volcanosh/vc-dashboard: exactly and does not allow for any optional suffixes (e.g., volcanosh/vc-dashboard-frontend:), whereas the comment on line 29 still indicates that suffixes are supported (volcanosh/vc-dashboard...:<tag>).
To maintain consistency with the documented behavior and allow for potential future sub-images, we should update the regex to match optional suffixes using [^[:space:]:]* before the colon.
| # Match image name volcanosh/vc-dashboard, then :tag | |
| sed -i.bak "s|\(volcanosh/vc-dashboard:\)[^[:space:]]*|\1${NEW_TAG}|g" "${f}" | |
| # Match image name volcanosh/vc-dashboard with optional suffix, then :tag | |
| sed -i.bak "s|\(volcanosh/vc-dashboard[^[:space:]:]*:\)[^[:space:]]*|\1${NEW_TAG}|g" "${f}" |
The release workflow pushes volcanosh/vc-dashboard, but the deployment manifest referenced volcanosh/volcano-dashboard:latest which does not exist on Docker Hub. Align manifest, docs, and bump script with CI. Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
fe0d04f to
0f093c1
Compare
What type of PR is this? (check all applicable)
Description
The published install manifest references
volcanosh/volcano-dashboard:latest, but the release workflow (.github/workflows/release.yaml) pushesvolcanosh/vc-dashboard:latestto Docker Hub. Thevolcanosh/volcano-dashboardrepository does not exist, so a fresh install fails with ImagePullBackOff.This PR aligns the manifest, docs, and version-bump script with the image CI actually publishes.
Changes
deployment/volcano-dashboard.yaml— usevolcanosh/vc-dashboard:latestREADME.md/CONTRIBUTING.md— update documented default image namehack/bump-dashboard-version.sh— updatesedpattern to bumpvolcanosh/vc-dashboardtagsFixes #295
Related issue
volcanosh/volcano-dashboard:latestTest plan
kubectl apply -f deployment/volcano-dashboard.yamlkubectl -n volcano-system get pods -l app=volcano-dashboardkubectl -n volcano-system port-forward svc/volcano-dashboard 8080:80DRY_RUN=1 hack/bump-dashboard-version.sh v1.0.0and verify it targetsvolcanosh/vc-dashboard