Skip to content

fix: align install manifest with published vc-dashboard image#297

Open
Pragati5-DEBUG wants to merge 1 commit into
volcano-sh:mainfrom
Pragati5-DEBUG:fix/dashboard-image-name
Open

fix: align install manifest with published vc-dashboard image#297
Pragati5-DEBUG wants to merge 1 commit into
volcano-sh:mainfrom
Pragati5-DEBUG:fix/dashboard-image-name

Conversation

@Pragati5-DEBUG

Copy link
Copy Markdown

What type of PR is this? (check all applicable)

  • 🐛 Bug Fix

Description

The published install manifest references volcanosh/volcano-dashboard:latest, but the release workflow (.github/workflows/release.yaml) pushes volcanosh/vc-dashboard:latest to Docker Hub. The volcanosh/volcano-dashboard repository does not exist, so a fresh install fails with ImagePullBackOff.

This PR aligns the manifest, docs, and version-bump script with the image CI actually publishes.

Changes

  • deployment/volcano-dashboard.yaml — use volcanosh/vc-dashboard:latest
  • README.md / CONTRIBUTING.md — update documented default image name
  • hack/bump-dashboard-version.sh — update sed pattern to bump volcanosh/vc-dashboard tags

Fixes #295

Related issue

Test plan

  • Apply manifest: kubectl apply -f deployment/volcano-dashboard.yaml
  • Confirm pod pulls image: kubectl -n volcano-system get pods -l app=volcano-dashboard
  • Port-forward and open UI: kubectl -n volcano-system port-forward svc/volcano-dashboard 8080:80
  • (Optional) Run DRY_RUN=1 hack/bump-dashboard-version.sh v1.0.0 and verify it targets volcanosh/vc-dashboard

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the Docker image from volcanosh/volcano-dashboard to volcanosh/vc-dashboard across the documentation, deployment manifests, and helper scripts. The review feedback points out that the updated sed pattern in the version-bumping script no longer supports optional image suffixes (such as -frontend), which contradicts the script's documentation. A code suggestion is provided to restore support for optional suffixes in the regular expression.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +85 to +86
# Match image name volcanosh/vc-dashboard, then :tag
sed -i.bak "s|\(volcanosh/vc-dashboard:\)[^[:space:]]*|\1${NEW_TAG}|g" "${f}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The updated sed pattern only matches volcanosh/vc-dashboard: exactly and does not allow for any optional suffixes (e.g., volcanosh/vc-dashboard-frontend:), whereas the comment on line 29 still indicates that suffixes are supported (volcanosh/vc-dashboard...:<tag>).

To maintain consistency with the documented behavior and allow for potential future sub-images, we should update the regex to match optional suffixes using [^[:space:]:]* before the colon.

Suggested change
# Match image name volcanosh/vc-dashboard, then :tag
sed -i.bak "s|\(volcanosh/vc-dashboard:\)[^[:space:]]*|\1${NEW_TAG}|g" "${f}"
# Match image name volcanosh/vc-dashboard with optional suffix, then :tag
sed -i.bak "s|\(volcanosh/vc-dashboard[^[:space:]:]*:\)[^[:space:]]*|\1${NEW_TAG}|g" "${f}"

The release workflow pushes volcanosh/vc-dashboard, but the deployment manifest referenced volcanosh/volcano-dashboard:latest which does not exist on Docker Hub. Align manifest, docs, and bump script with CI.

Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install manifest uses non-existent image volcanosh/volcano-dashboard:latest

2 participants