Skip to content

fix: grant pod mutation verbs in dashboard ClusterRole#296

Open
Pragati5-DEBUG wants to merge 1 commit into
volcano-sh:mainfrom
Pragati5-DEBUG:fix/pod-delete-rbac
Open

fix: grant pod mutation verbs in dashboard ClusterRole#296
Pragati5-DEBUG wants to merge 1 commit into
volcano-sh:mainfrom
Pragati5-DEBUG:fix/pod-delete-rbac

Conversation

@Pragati5-DEBUG

Copy link
Copy Markdown

Pod delete in UI returns 403 because RBAC only had get/list/watch on pods; jobs got delete in #152 but pods were missed.

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign william-wang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

Welcome @Pragati5-DEBUG! It looks like this is your first PR to volcano-sh/dashboard 🎉

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the RBAC rules in deployment/volcano-dashboard.yaml to include 'create', 'delete', 'update', and 'patch' permissions. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants