Skip to content

Instead of relying on the reactive state query parameter with .refetch(), fetch the YAML dynamically #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniket866 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Instead of relying on the reactive state query parameter with .refetch(), fetch the YAML dynamically #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions apps/web/src/components/(dashboard)/jobs/jobs-management.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,19 +62,7 @@ export default function JobsManagement() {
}
)

const jobYamlQuery = trpc.jobsRouter.getJobYaml.useQuery(
{
namespace: selectedJob?.namespace || "",
name: selectedJob?.name || "",
},
{
enabled: false,
onError: (err) => {
console.error("Error fetching job YAML:", err);
setError(`Job YAML API error: ${err.message}`);
},
},
);


const availableNamespaces = jobs ?
Array.from(new Set(jobs.map(job => job.namespace).filter(Boolean))).sort()
Expand Down Expand Up @@ -210,15 +198,17 @@ export default function JobsManagement() {
setError(null);

try {
const response = await jobYamlQuery.refetch();
const yaml = response.data || job.yaml || "";
setSelectedJob({ ...job, yaml });
const yaml = await utils.jobsRouter.getJobYaml.fetch({
namespace: job.namespace,
name: job.name
});
setSelectedJob({ ...job, yaml: yaml || "" });
setShowJobDetails(true);
} catch (err) {
setError("Failed to fetch job YAML");
console.error(err)
}
}, [jobYamlQuery]);
}, [utils]);
Comment thread
aniket866 marked this conversation as resolved.

const handleJobCreate = () => {
setShowCreateJobModal(true)
Expand Down
24 changes: 7 additions & 17 deletions apps/web/src/components/(dashboard)/pods/pod-management.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,19 +67,7 @@ export default function PodManagement() {
)


const podYamlQuery = trpc.podRouter.getPodYaml.useQuery(
{
namespace: selectedPod?.namespace || "",
name: selectedPod?.name || ""
},
{
enabled: false,
onError: (err) => {
console.error("Error fetching pod YAML:", err);
setError(`Pod YAML API error: ${err.message}`);
},
},
);


const availableNamespaces = pods ?
Array.from(new Set(pods.map(pod => pod.namespace).filter(Boolean))).sort()
Expand Down Expand Up @@ -204,15 +192,17 @@ export default function PodManagement() {
setError(null);

try {
const response = await podYamlQuery.refetch();
const yaml = response.data || pod.yaml || "";
setSelectedPod({ ...pod, yaml });
const yaml = await utils.podRouter.getPodYaml.fetch({
namespace: pod.namespace,
name: pod.name
});
setSelectedPod({ ...pod, yaml: yaml || "" });
setShowPodDetails(true);
} catch (err) {
setError("Failed to fetch pod YAML");
console.error(err)
}
}, [podYamlQuery])
}, [utils])
Comment thread
aniket866 marked this conversation as resolved.

const handlePodCreate = () => {
setShowCreatePodModal(true)
Expand Down
20 changes: 6 additions & 14 deletions apps/web/src/components/(dashboard)/queues/queue-management.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,7 @@ export default function QueueManagement() {
onDelete: handleDelete
})

const queueYamlQuery = trpc.queueRouter.getQueueYaml.useQuery(
{ name: selectedQueue?.name || "" },
{
enabled: false,
onError: (err) => {
console.error("Error fetching queue YAML:", err);
setError(`Queue YAML API error: ${err.message}`);
},
},
);


useEffect(() => {
if (queuesQuery.data) {
Expand Down Expand Up @@ -202,15 +193,16 @@ export default function QueueManagement() {
setError(null);

try {
const response = await queueYamlQuery.refetch();
const yaml = response.data || queue.yaml || "";
setSelectedQueue({ ...queue, yaml });
const yaml = await utils.queueRouter.getQueueYaml.fetch({
name: queue.name
});
setSelectedQueue({ ...queue, yaml: yaml || "" });
setShowQueueDetails(true);
} catch (err) {
setError("Failed to fetch queue YAML");
console.error(err)
}
}, [queueYamlQuery])
}, [utils])
Comment thread
aniket866 marked this conversation as resolved.

const handleCreateQueue = () => {
setShowCreateQueueModal(true)
Expand Down
Loading