Skip to content

netstat: add cycle detection to Next pointer walk #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TristanInSec wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −0
Open

netstat: add cycle detection to Next pointer walk #1997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions volatility3/framework/plugins/windows/netstat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,16 @@ def enumerate_structures_by_port(

# if the same port is used on different interfaces multiple objects are created
# those can be found by following the pointer within the object's `Next` field until it is empty
seen_addresses = set()
while next_obj_address:
if next_obj_address in seen_addresses:
vollog.warning(
"Cycle detected in Next pointer at %#x, stopping walk",
next_obj_address,
)
return
seen_addresses.add(next_obj_address)

try:
curr_obj = context.object(
obj_name,
Expand Down