Skip to content

Apply fixes from StyleCI#135

Merged
voku merged 1 commit into
masterfrom
analysis-V0OoO3
Apr 23, 2026
Merged

Apply fixes from StyleCI#135
voku merged 1 commit into
masterfrom
analysis-V0OoO3

Conversation

@voku

@voku voku commented Apr 23, 2026

Copy link
Copy Markdown
Owner

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.


This change is Reviewable

Summary by CodeRabbit

  • Style
    • Code formatting and structural alignment improvements for better maintainability.

@sonarqubecloud

Copy link
Copy Markdown

@voku voku merged commit cf86577 into master Apr 23, 2026
13 of 16 checks passed
@coveralls

coveralls commented Apr 23, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 95.731%. remained the same — analysis-V0OoO3 into master

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consists of indentation and whitespace formatting adjustments within the domNodeClosingTagOptional and domNodeOpeningTagOptional methods in src/voku/helper/HtmlMin.php to improve code consistency. I have no feedback to provide.

@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ae629012-b123-4690-a598-5cf23cc17da1

📥 Commits

Reviewing files that changed from the base of the PR and between 052caf4 and b7a2cbd.

📒 Files selected for processing (1)
  • src/voku/helper/HtmlMin.php

Walkthrough

Indentation and parenthesis alignment adjustments within boolean return expressions in two methods (domNodeClosingTagOptional and domNodeOpeningTagOptional) of the HtmlMin class. No logical changes or functional modifications.

Changes

Cohort / File(s) Summary
Formatting Updates
src/voku/helper/HtmlMin.php
Adjusted indentation and bracing alignment in domNodeClosingTagOptional and domNodeOpeningTagOptional methods for conditional tag name checks ('rp', 'option', 'p', 'colgroup', and array-based conditions). Logic and predicates unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

Indents aligned, the brackets dance,
In graceful rows, no logic's chance,
Just whitespace waltz and spacing cheer,
The code flows cleaner, crystal clear.
A rabbit's work, both neat and right! 🐰

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch analysis-V0OoO3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants