global SSL configuration inheritance and SSL_CERT_FILE environment variable#576
Merged
Conversation
Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
85ffca4 to
700dddf
Compare
sshedi
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces global SSL configuration inheritance and
SSL_CERT_FILEenvironment variable support totdnf, ensuring that SSL settings follow a canonical precedence hierarchy.Previously,
sslcacerthad to be explicitly defined in every single.repofile, which was problematic for transparent MITM proxies. Additionally,tdnfdid not respect the standardSSL_CERT_FILEenvironment variable.Changes Made
sslcacert,sslclientcert, andsslclientkeyin the[main]section oftdnf.conf. These settings are now inherited by all repositories unless explicitly overridden.SSL_CERT_FILEenvironment variable to override configuration files.--setopt=sslcacert=...or--setopt=repoid.sslcacert=...)SSL_CERT_FILE).repofiles)tdnf.conf)pszSnapshotUrlandpszSnapshotFilewere not being freed when destroying repository data structures. ConsolidatedTDNFFreeReposInternalandTDNFFreeReposto prevent future drift.test_ssl_config.py) that spins up a local HTTPS server with self-signed certificates to verify the new inheritance and precedence logic. UpdatedTestUtils.run()inconftest.pyto accept custom environment variables for testing.