Skip to content

fix: multiple memmove and memcpy calls in the core s... in...#670

Open
orbisai0security wants to merge 1 commit into
vmware:mainfrom
orbisai0security:fix-routing-filter-encoding-size-bounds-check
Open

fix: multiple memmove and memcpy calls in the core s... in...#670
orbisai0security wants to merge 1 commit into
vmware:mainfrom
orbisai0security:fix-routing-filter-encoding-size-bounds-check

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix critical severity security issue in src/routing_filter.c.

Vulnerability

Field Value
ID V-001
Severity CRITICAL
Scanner multi_agent_ai
Rule V-001
File src/routing_filter.c:624
CWE CWE-120

Description: Multiple memmove and memcpy calls in the core storage engine do not verify that the source data length fits within the destination buffer before copying. In routing_filter.c:624, the variable encoding_size is used directly as the copy length without checking it against the allocated size of hdr->encoding. In routing_filter.c:803, MAX_FILTERS * sizeof(uint32) bytes are copied from fp_start without verifying the source region is at least that large. A caller supplying crafted key/value data or filter metadata can trigger heap buffer overflows, overwriting adjacent heap memory and corrupting internal data structures.

Changes

  • src/routing_filter.c

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by Orbis Security AI
@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for splinterdb canceled.

Name Link
🔨 Latest commit 8ebd925
🔍 Latest deploy log https://app.netlify.com/projects/splinterdb/deploys/6a06c13b64cf5d0008e0775e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant