Skip to content
This repository was archived by the owner on Mar 15, 2021. It is now read-only.

Wavefront, Influx, OpenTSDB DCC and packages for wavefront, influx, opentsdb.#184

Open
lucifercr07 wants to merge 1 commit into
vmware-archive:masterfrom
lucifercr07:tsdb
Open

Wavefront, Influx, OpenTSDB DCC and packages for wavefront, influx, opentsdb.#184
lucifercr07 wants to merge 1 commit into
vmware-archive:masterfrom
lucifercr07:tsdb

Conversation

@lucifercr07

Copy link
Copy Markdown

Added wavefront, influx, opentsdb DCCs and packages for wavefront, influx, opentsdb along with them examples for the DCCs.

@KohliDev

Copy link
Copy Markdown
Contributor

@Venkat2811 Please review the code.

@Venkat2811 Venkat2811 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphite, Wavefront, Influx, TSDB, AWSIoT DCCs have same register and create relationship implementation.

@pmasrani @KohliDev As discussed few months ago, we should make this implementation as part of Abstract DCC now.

Comment thread liota/dccs/influx.py
else:
host = (reg_metric.parent).ref_entity.entity_id #if device is not available, only gateway uuid

metric_unit = str(reg_metric.ref_entity.unit)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parse unit is available in si_unit.py. Please use that.

Comment thread liota/dccs/wavefront.py
else:
host = (reg_metric.parent).ref_entity.entity_id #if device is not available, only gateway uuid

metric_unit = str(reg_metric.ref_entity.unit)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parse unit is available in si_unit.py. Please use that.

Comment thread liota/dccs/influx.py

def _format_data(self, reg_metric):
met_cnt = reg_metric.values.qsize()
message = ''

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create these variables after met_cnt validation

Comment thread liota/dccs/opentsdb.py

def _format_data(self, reg_metric):
met_cnt = reg_metric.values.qsize()
message = ''

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create these variables after met_cnt validation

Comment thread liota/dccs/wavefront.py

def _format_data(self, reg_metric):
met_cnt = reg_metric.values.qsize()
message = ''

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants