Replace custom AsyncEvaluator with torchrl Evaluator - #63
Open
vmoens wants to merge 1 commit into
Open
Conversation
Use the unified Evaluator from torchrl.collectors instead of the hand-rolled AsyncEvaluator class and run_eval/collect_eval_result helpers. The torchrl Evaluator handles weight transfer, video dumping, and metric logging internally for both sync and async modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncEvaluatorclass andrun_eval/collect_eval_result/log_eval_resulthelpers with the unifiedEvaluatorfromtorchrl.collectorsEvaluatorhandles weight transfer, video dumping, and metric logging internally for both sync (evaluate()) and async (trigger_eval()/poll()) modesqueue,threading,ExplorationType,set_exploration_typeimports that were only used by the removed codeTest plan
🤖 Generated with Claude Code