Skip to content

Replace custom AsyncEvaluator with torchrl Evaluator - #63

Open
vmoens wants to merge 1 commit into
mainfrom
fix-evaluator
Open

Replace custom AsyncEvaluator with torchrl Evaluator#63
vmoens wants to merge 1 commit into
mainfrom
fix-evaluator

Conversation

@vmoens

@vmoens vmoens commented Apr 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Replaced the hand-rolled AsyncEvaluator class and run_eval/collect_eval_result/log_eval_result helpers with the unified Evaluator from torchrl.collectors
  • The torchrl Evaluator handles weight transfer, video dumping, and metric logging internally for both sync (evaluate()) and async (trigger_eval()/poll()) modes
  • Removed queue, threading, ExplorationType, set_exploration_type imports that were only used by the removed code

Test plan

  • Run humanoid PPO training without compilation to verify basic functionality
  • Run humanoid PPO training with compilation on both collector and evaluator envs
  • Verify eval metrics and videos are logged to WandB correctly

🤖 Generated with Claude Code

Use the unified Evaluator from torchrl.collectors instead of the
hand-rolled AsyncEvaluator class and run_eval/collect_eval_result
helpers. The torchrl Evaluator handles weight transfer, video dumping,
and metric logging internally for both sync and async modes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant