[Bugfix] Clean distributed state after worker initialization failure#49834
Closed
AndreasKaratzas wants to merge 1 commit into
Closed
[Bugfix] Clean distributed state after worker initialization failure#49834AndreasKaratzas wants to merge 1 commit into
AndreasKaratzas wants to merge 1 commit into
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com> Signed-off-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkerProcconstruction completes.With
spawn, constructor failure can occur after global groups and their shared-memory queue are initialized but before aWorkerProcexists to own normal shutdown.Validation
Buildkite: Model Executor
Duplicate check: #34816 handles parent-death signals, not constructor failure; no open PR addresses this ownership path.
AI assistance: Codex assisted with investigation, implementation, and validation; Andreas directed the ownership design and reviewed the resulting changes.