[Test][ROCm] Account for gfx950 FP8 RMSNorm rounding#49832
Closed
AndreasKaratzas wants to merge 1 commit into
Closed
[Test][ROCm] Account for gfx950 FP8 RMSNorm rounding#49832AndreasKaratzas wants to merge 1 commit into
AndreasKaratzas wants to merge 1 commit into
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com> Signed-off-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allclosecontract only for the measured gfx950 fused RMSNorm cases.E4M3 adjacent codes can differ by 12.5%, and its minimum subnormal step is approximately 0.002. Fused and unfused gfx950 reductions selected adjacent codes at those boundaries; no production kernel changed.
Validation
Buildkite: Kernels Core Operation
Duplicate check: no open PR covers these tests; #49621 changes separate per-group quantization files.
AI assistance: Codex assisted with investigation, implementation, and validation; Andreas directed the numerical contract and reviewed the resulting changes.