Skip to content

[Test][ROCm] Account for gfx950 FP8 RMSNorm rounding#49832

Closed
AndreasKaratzas wants to merge 1 commit into
mainfrom
agent/gfx950-fp8-rmsnorm-tests
Closed

[Test][ROCm] Account for gfx950 FP8 RMSNorm rounding#49832
AndreasKaratzas wants to merge 1 commit into
mainfrom
agent/gfx950-fp8-rmsnorm-tests

Conversation

@AndreasKaratzas

Copy link
Copy Markdown
Member

Summary

  • Use the shared FP8 allclose contract only for the measured gfx950 fused RMSNorm cases.
  • Bound every accepted difference to one FP8 ULP while leaving scales, residuals, other dtypes, other architectures, and other ROCm checks unchanged.

E4M3 adjacent codes can differ by 12.5%, and its minimum subnormal step is approximately 0.002. Fused and unfused gfx950 reductions selected adjacent codes at those boundaries; no production kernel changed.

Validation

  • Original Buildkite failures: 39 passed.
  • Final changed scope: 162 static cases passed; dynamic scope had 304 passed and 152 expected parameter skips.
  • Earlier complete matrices passed 648 static and 1,128 dynamic cases; changed-file pre-commit passed.

Buildkite: Kernels Core Operation

Duplicate check: no open PR covers these tests; #49621 changes separate per-group quantization files.

AI assistance: Codex assisted with investigation, implementation, and validation; Andreas directed the numerical contract and reviewed the resulting changes.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@mergify mergify Bot added the rocm Related to AMD ROCm label Jul 25, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Jul 25, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Jul 25, 2026
@AndreasKaratzas
AndreasKaratzas deleted the agent/gfx950-fp8-rmsnorm-tests branch July 25, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant