Add DSpark algorithm page#849
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughChangesDSpark documentation
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/user_guide/algorithms/dspark.md`:
- Around line 17-19: Update the “Confidence Head” section to explain that
confidence scores are conditional on preceding draft-token acceptance, that
DSpark cumulatively computes prefix-survival probabilities, and that a
hardware-aware scheduler selects verification length rather than applying
independent scores or a simple threshold. Include a concise example consistent
with the current API and speculative decoding behavior.
- Line 3: Update the DSpark architecture description around the vLLM deployment
statement to remove the claim that its deployment path is unchanged. State that
the workflow is similar to DFlash but requires DSpark-aware vLLM serving support
and configuration, including the dedicated dspark method and sequential Markov
sampling.
- Around line 37-39: Update the “Pretrained Models” section in dspark.md to
remove the claim that no pretrained DSpark models exist. Link to the available
RedHatAI DSpark checkpoints, including RedHatAI/GLM-5.2-speculator.dspark, or
explicitly limit the statement to models provided within this repository while
retaining the training example.
- Line 15: Update the DSpark algorithm documentation around the `--markov-rank
0` guidance to include `--no-confidence-head-with-markov`, and also document
`--no-enable-confidence-head` when pure DFlash behavior is intended. Ensure the
documented command-line options produce a valid `DSparkDraftModel` configuration
with `markov_rank=0`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d371da7f-b138-4cbc-93df-200be22e80e7
📒 Files selected for processing (4)
docs/.nav.ymldocs/user_guide/algorithms/decision_guide.mddocs/user_guide/algorithms/dspark.mddocs/user_guide/algorithms/index.md
7a86bf3 to
84890b5
Compare
|
Pointed the GLM link at the actual repo (GLM-5.2-speculator.dspark-preview) and dropped the gemma row since |
b198c2b to
f8fe2bf
Compare
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Require approval from approved reviewers listAll pull requests must have at least one approving review from a member of the approved reviewers list before merging.
|
Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
f8fe2bf to
f24d415
Compare
…s in favor of vllm-project#849 Signed-off-by: Ranran Haoran Zhang <ranzhang@redhat.com>
|
The quality checks have failed. Please run |
Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
Head branch was pushed to by a user without write access
|
Fixed the quality issue. Please take another look, thanks! |
Purpose
DSpark is supported in the trainer but has no algorithm page (followup from #840). Adds documentation covering the Markov and confidence heads, the
DSpark-specificflags and their defaults, and wires it into the nav, the algorithms index, and the decision guide.cc @WindChimeRan
Tests
Docs-only.
make qualitypasses.Checklist
I have filled in: