fix: 2 improvements across 2 files#807
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Quality: Typo in docstring: 'liklihood' - Quality: Typo in docstring: 'sequnce' Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Quality: Typo in docstring: 'liklihood' - Quality: Typo in docstring: 'sequnce' Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesDocumentation corrections
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fynnsu
approved these changes
Jul 17, 2026
fynnsu
left a comment
fynnsu
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Please fix DCO
rahul-tuli
approved these changes
Jul 18, 2026
Collaborator
|
We are good to land this once the diff is rebased, and DCO is fixed! Thanks for your contribution |
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Require approval from approved reviewers listAll pull requests must have at least one approving review from a member of the approved reviewers list before merging.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: 2 improvements across 2 files
Problem
Severity:
Low| File:src/speculators/proposals/greedy.py:L75The
accept_tolerancefield description inGreedyTokenProposalConfigcontains a typo: 'liklihood' should be 'likelihood'.Solution
Correct the spelling of 'likelihood' in the docstring.
Changes
src/speculators/proposals/greedy.py(modified)src/speculators/models/peagle/attention.py(modified)