fix: web search call output ordering - #157
Conversation
Signed-off-by: maral <maralbahari.98@gmail.com>
Signed-off-by: maral <maralbahari.98@gmail.com>
|
I prepared and validated the follow-up for the accumulator issues found in review:
The fix is commit Verification: |
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: maral <maralbahari.98@gmail.com>
thanks I also re-recoded the cassettes and added integration test for web search action. |
franciscojavierarceo
left a comment
There was a problem hiding this comment.
The ordering fix, documented web-search action variants, provisional-item handling, and missing-ID reconciliation are covered by focused regressions and recorded gateway/OpenAI comparisons. The final head is mergeable and all required checks pass.
Summary
Fixes #156 by preserving upstream
output_indexordering for streamingweb_search_callitems relative to reasoning, messages, and other output items.response.output_item.addedthroughresponse.output_item.done, with fallback support for providers that omit the added event.search,open_page, andfind_in_page.Test Plan
cargo test --workspace -- --test-threads=8cargo clippy --all-targets -- -D warningscargo fmt --all -- --check