scanner: refactor new_plain_scanner to accept file_path, file_base an…#27199
Open
whisky-jb wants to merge 1 commit into
Open
scanner: refactor new_plain_scanner to accept file_path, file_base an…#27199whisky-jb wants to merge 1 commit into
whisky-jb wants to merge 1 commit into
Conversation
Member
|
15 ci errors (master is green now) |
Contributor
Author
Tried to merge latest master, but still getting errors, unrelated to my change? |
Member
|
1 sanitized job times out on master. Your PR has 13 failing. |
Contributor
Author
|
I'm unclear why this is not merged, can you provide me some more details? Still learning how to contribute, so some guidance appreciated. |
Contributor
Author
|
try again |
new_scanner_file now uses new_plain_scanner as its base, eliminating the duplicated Scanner struct initialization.
Member
|
Don't worry, I'll fix your PR myself today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor scanner, duplicated code consolidated.