chore: bump vizia pin to current main (3d04965d) - #19
Closed
paravozz wants to merge 1 commit into
Closed
Conversation
Bumps the `vizia` and `vizia_reactive` pin from `23e34039` (the vizia#672 merge commit, set when vizia#17 landed) to `3d04965d` (current vizia/main tip). Picks up two follow-up vizia merges: - vizia/vizia#674 (`59158cfd`) — `vizia_baseview` Cmd+Q parented fix. `requests_exit` no longer treats Cmd+Q as an exit when the application is parented in a host (resolves the Bitwig case where Cmd+Q tore down a plug-in's GL surface). - vizia/vizia#676 (`3d04965d`) — bump vizia's baseview rev to pull in RustAudio/baseview#228 (macOS first-click hitTest fix) + #233 (cargo-clippy cfg-lint workaround) on top of the existing keyboard-types 0.7 carry. No vizia-plug-side code changes needed; both merges are behavioural fixes inside the vizia/vizia_baseview crates that vizia-plug already depends on.
Contributor
Author
|
duplicates #18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17. Bumps the
vizia/vizia_reactivepin from23e34039(the vizia#672 merge commit set when #17 landed) to3d04965d(current vizia/main tip). Picks up two follow-up vizia merges:59158cfd) —vizia_baseviewCmd+Q parented fix.requests_exitno longer treats Cmd+Q as an exit when the application is parented in a host. Resolves a Bitwig-on-macOS case where Cmd+Q tore down a plug-in's GL surface mid-session while the user was just trying to quit the DAW.3d04965d) — bump vizia's baseview rev. Pulls in fix(macos): route first click in non-key window to mouseDown: via hitTest: override RustAudio/baseview#228 (macOS first-clickhitTest:fix) and move #![allow(unexpected_cfgs)] to crate root RustAudio/baseview#233 (cargo-clippycfglint workaround) on top of the existing keyboard-types 0.7 carry.No vizia-plug-side code changes needed; both upstream merges are behavioural fixes inside
vizia/vizia_baseviewthat vizia-plug already depends on.cargo checkclean against the new pin.