Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts bootstrap-related documentation and the bootstrap/build.sh script, but the current script changes appear inconsistent with the rest of the bootstrap toolchain in the repository.
Changes:
- Updates
third_party/README.mdBinaryen placeholder text (currently truncated in the diff). - Changes the bootstrap build script to call
vixc2and producevixc3instead ofvixc0/vixc1.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| third_party/README.md | Updates the Binaryen placeholder note (currently left incomplete). |
| bootstrap/build.sh | Renames the invoked compiler and output binary in the bootstrap build script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2
to
+4
| ./vixc2 main.vix > main.ll | ||
| clang -c main.ll -o vixc1.o | ||
| clang -o vixc1 vixc1.o helper.o $(llvm-config --ldflags --libs) | ||
| clang -o vixc3 vixc1.o helper.o $(llvm-config --ldflags --libs) |
| @@ -1 +1 @@ | |||
| Binaryen source goes here (for Emscripten build) | |||
| Binaryen source goes here ( | |||
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| ./vixc0 main.vix > main.ll | |||
| ./vixc2 main.vix > main.ll | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.