[FIX] Use server SSH port for default Firewall Rules#1086
Open
RichardAnderson wants to merge 1 commit into
Open
[FIX] Use server SSH port for default Firewall Rules#1086RichardAnderson wants to merge 1 commit into
RichardAnderson wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes firewall/UFW installation behavior to respect a server’s configured SSH port (instead of hardcoding port 22), addressing the lockout scenario described in issue #1082.
Changes:
- Seed the default “SSH” firewall rule using the server’s configured SSH port (fallback 22).
- Pass the server SSH port into the UFW install script template and use it when opening the SSH rule.
- Add unit tests to validate firewall rule seeding behavior for custom/default SSH ports.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
app/Services/Firewall/AbstractFirewall.php |
Seeds the SSH firewall rule with the server’s configured SSH port (fallback 22). |
app/Services/Firewall/Ufw.php |
Passes sshPort into the UFW install view so the script can open the correct port. |
resources/views/ssh/services/firewall/ufw/install-ufw.blade.php |
Uses the provided sshPort instead of hardcoding 22 in the UFW allow command. |
tests/Unit/SSH/Services/Firewall/UfwInstallTest.php |
Adds tests for seeding SSH rule with custom/default port and keeping HTTP/HTTPS unchanged. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way the SSH port is handled during firewall rule creation and UFW installation, allowing for custom SSH ports instead of assuming the default port 22. It also adds comprehensive tests to ensure this behavior is correct. The main improvements are grouped into logic updates, template changes, and new tests.
Firewall logic and behavior updates:
AbstractFirewall.php.Ufw.php.Template/script changes:
install-ufw.blade.php) now dynamically uses the provided SSH port instead of hardcoding port 22.Testing improvements:
UfwInstallTest.php) to verify that:Resolves #1082