[FIX] v3.x: Preserve import flash for non-database session drivers#1079
Closed
erhanurgun wants to merge 1 commit into
Closed
[FIX] v3.x: Preserve import flash for non-database session drivers#1079erhanurgun wants to merge 1 commit into
erhanurgun wants to merge 1 commit into
Conversation
erhanurgun
force-pushed
the
fix/import-flash-non-database-session
branch
from
5e26916 to
e88c57b
Compare
erhanurgun
changed the title
Settings import unconditionally switched the active session driver to file so that the in-progress sqlite swap could not destroy the active session. On the default redis driver this rerouted the flash payload to a store the next request never reads, so the success toast never fired and the user was left guessing whether the import had run. Restrict the swap to the database driver, which is the only one that shares storage with the imported sqlite file. Adds two feature tests covering both branches.
erhanurgun
force-pushed
the
fix/import-flash-non-database-session
branch
from
e88c57b to
fa06402
Compare
Contributor
Author
|
Closing this. After deeper testing the fix does not address the observable behaviour: the success flash never reaches the next request even on the default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1080.
Default
SESSION_DRIVERisredis(config/session.php:21), so any install on the defaults runs into this. The unconditional swap to thefiledriver writes the success flash to a store the next request never reads, so the redirect comes back without a toast and the user has no way to tell whether the import worked.Limiting the swap to the
databasedriver leaves every other driver untouched. Behavior ondatabaseis unchanged.