feat: play a subtle tick at each minute boundary during Pomodoro#127
Open
syyam wants to merge 1 commit into
Open
feat: play a subtle tick at each minute boundary during Pomodoro#127syyam wants to merge 1 commit into
syyam wants to merge 1 commit into
Conversation
Adds a ToneGenerator-based tick cue at every minute mark while the pomodoro timer counts down. Volume is set to 40% of STREAM_NOTIFICATION so it is noticeable but not jarring. The cue is gated by the existing 'Enable In-App Sounds' setting and adds no new user-facing controls. No raw audio asset is required. Closes vishal2376#87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #87
Plays a short, low-volume audio cue at every minute mark while the Pomodoro timer is counting down. This gives the user an ambient signal that time is passing without requiring them to look at the screen.
Implementation
ToneGenerator(TONE_CDMA_ABBR_ALERT, 120 ms, 40% volume onSTREAM_NOTIFICATION) — no raw audio asset needed.SoundEvent.POMODORO_TICKto theSoundEventenum and aplayMinuteTick()private helper inAudioUtil.kt.PomodoroServiceinjectsSettingsStoreinonCreate()to track thesoundEnabledpreference, then fires the tick whennewLeft % 60 == 0L.Test plan