Restart video if it reaches the end#1
Open
Domratchev wants to merge 2 commits into
Open
Conversation
|
Can this be merged or at least looked at? (It looks correct to me and adds helpful typings) |
grizzly
approved these changes
Aug 22, 2019
Repository owner
deleted a comment from
Domratchev
Jan 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
'timeupdate' event frequency varies greatly as per https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/timeupdate_event and might be too low to fire before the video completion. It does fire once upon completion of the video, at which point the video gets paused and becomes useless.
We need to restart the video in such a case.
Additional Info
Possibly resolves richtr#39 and richtr#72, as the reduced frequency of 'timeupdate' calls is likely the root cause of those two issues.