🎨 Palette: Improve navigation accessibility with aria-labels#3
Conversation
- Added `aria-label` to `MobileNav` links using `item.title`. - Added `aria-label` to `DashboardNav` buttons using `item.label`. - Improves accessibility for screen readers by providing accessible names for icon-only buttons and links. Co-authored-by: vireapp <260846454+vireapp@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR improves the accessibility of the navigation menus by adding
aria-labelattributes to the links and buttons.Changes:
src/components/mobile-nav.tsx: Addedaria-label={item.title}to theLinkcomponents. This is crucial as these links only contain icons and decorative elements, making them inaccessible to screen readers without a label.src/components/dashboard-nav.tsx: Addedaria-label={item.label}to theButtoncomponents. While these have text labels, they are hidden on mobile viewports, leaving only the icon visible. Thearia-labelensures the purpose is announced even when the text is visually hidden.Verification:
aria-labelattributes on the rendered DOM elements.npm run lintandnpm run buildto ensure no regressions.PR created automatically by Jules for task 5488879342864255217 started by @vireapp