Do not require default features in nix#5
Open
tgockel wants to merge 1 commit into
Open
Conversation
This library does not require any features to be enabled in nix to work properly.
asomers
suggested changes
Aug 27, 2023
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
This is a definite improvement. However, it should also not use the * version. As a pre-1.0 crate, Nix does not guarantee API stability between minor versions. So prctl really needs to specify more exactly the range of compatible Nix versions.
Author
|
I don't know what the best practice for specifying that for pre-1.0 things is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library does not require any features to be enabled in nix to work properly.
The nix crate has a lot of features enabled in its default, which can cause problems if a downstream user does not want those enabled. I suspect nix was less feature-filled when this crate was last released 7 years ago, but now nix is quite large.