Add block level messages#867
Open
trktby wants to merge 1 commit into
Open
Conversation
Only labeled blocks are reported. BlockProcessedMessages are currently sent when the entire subtree rooted in the respective block has finished executing. Add parallel branch execution handling Use a path id and method names to communicate messages with execution paths. Update silver submodule Add flag "--generateBlockMessages" to enable block level reporting Also fix minor bug causing crashes for empty blocks. Fix path ids not being incremented in non-parallelized branches Add emission of BlockFailureMessages, clean up a bit There were issues with the --numErrorsToReport option. PathProcessedMessages may have emitted false results since the result of the last explored block did not match the expected path result. It was success if the last explored block succeeded, while it was expected to be Failure if any block on the path failed. Now the message should merely signify that the path has finished. Simplify path completion tracking Whitespace fix
Aurel300
force-pushed
the
report_cfg_times
branch
from
b4b3ddc to
2edb3fc
Compare
Member
|
@marcoeilers I would like to merge this, could you take a look? I think most of this is fine because most of it doesn't kick in without the command-line flag. There is the extra atomic integer which we generate for each new branch -- do you think this might have an impact? My intuition is that the cost of actually executing any branch far outweighs the cost of synchronisation here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to provide more granular progress reporting for the Prusti-Assistant VS Code extension. It is part of a practical work supervised by @Aurel300. It depends on a corresponding Silver PR.
The new Silver messages are emitted during execution. New information for tracking progress is added to the
ExecutorandState, and kept up to date if a new--generateBlockMessagesflag is set.This information includes:
currentBlockfield in theState, comprised of a label and path id.