Skip to content

feat: add wasi support#81

Open
vincent-herlemont wants to merge 1 commit into
mainfrom
wasi_support
Open

feat: add wasi support#81
vincent-herlemont wants to merge 1 commit into
mainfrom
wasi_support

Conversation

@vincent-herlemont

@vincent-herlemont vincent-herlemont commented Dec 28, 2023

Copy link
Copy Markdown
Owner

@vincent-herlemont

Copy link
Copy Markdown
Owner Author

Fail on tests:

error[E0433]: failed to resolve: could not find `unix` in `os`
   --> /home/vincentherlemont/.cargo/registry/src/index.crates.io-6f17d22bba15001f/assert_fs-1.1.0/src/fixture/tools.rs:376:14
    |
376 |     std::os::unix::fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
    |              ^^^^ could not find `unix` in `os`
    |
help: consider importing this module
    |
3   + use std::os::wasi::fs;
    |
help: if you import `fs`, refer to it directly
    |
376 -     std::os::unix::fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
376 +     fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
    |

error[E0433]: failed to resolve: could not find `unix` in `os`
   --> /home/vincentherlemont/.cargo/registry/src/index.crates.io-6f17d22bba15001f/assert_fs-1.1.0/src/fixture/tools.rs:382:14
    |
382 |     std::os::unix::fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
    |              ^^^^ could not find `unix` in `os`
    |
help: consider importing this module
    |
3   + use std::os::wasi::fs;
    |
help: if you import `fs`, refer to it directly
    |
382 -     std::os::unix::fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
382 +     fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
    |

@vincent-herlemont vincent-herlemont changed the title feat: support wasi feat: wasi support Dec 28, 2023
@vincent-herlemont vincent-herlemont changed the title feat: wasi support feat: add wasi support Dec 28, 2023
@GregoryConrad

Copy link
Copy Markdown

As a heads up, iirc, FileExt won’t be stabilized for WASI until years from now since WASI itself isn’t stable. You should probably add a nightly cargo feature and then require users to enable it when FileExt is needed

@vincent-herlemont

Copy link
Copy Markdown
Owner Author

As a heads up, iirc, FileExt won’t be stabilized for WASI until years from now since WASI itself isn’t stable. You should probably add a nightly cargo feature and then require users to enable it when FileExt is needed

Ho okay, thanks for the information. I will do that.

@vincent-herlemont vincent-herlemont added the browser-support Browser support label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser-support Browser support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants