feat: add wasi support#81
Open
vincent-herlemont wants to merge 1 commit into
Open
Conversation
Owner
Author
|
Fail on tests: error[E0433]: failed to resolve: could not find `unix` in `os`
--> /home/vincentherlemont/.cargo/registry/src/index.crates.io-6f17d22bba15001f/assert_fs-1.1.0/src/fixture/tools.rs:376:14
|
376 | std::os::unix::fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
| ^^^^ could not find `unix` in `os`
|
help: consider importing this module
|
3 + use std::os::wasi::fs;
|
help: if you import `fs`, refer to it directly
|
376 - std::os::unix::fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
376 + fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
|
error[E0433]: failed to resolve: could not find `unix` in `os`
--> /home/vincentherlemont/.cargo/registry/src/index.crates.io-6f17d22bba15001f/assert_fs-1.1.0/src/fixture/tools.rs:382:14
|
382 | std::os::unix::fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
| ^^^^ could not find `unix` in `os`
|
help: consider importing this module
|
3 + use std::os::wasi::fs;
|
help: if you import `fs`, refer to it directly
|
382 - std::os::unix::fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
382 + fs::symlink(target, link).chain(FixtureError::new(FixtureKind::Symlink))?;
| |
|
As a heads up, iirc, FileExt won’t be stabilized for WASI until years from now since WASI itself isn’t stable. You should probably add a nightly cargo feature and then require users to enable it when FileExt is needed |
Owner
Author
Ho okay, thanks for the information. I will do that. |
104e73c to
5f1248d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #65