feat: add DateTime sentinel value support to test_sentinel_value_approach#444
Open
vincent-herlemont wants to merge 1 commit into
Open
feat: add DateTime sentinel value support to test_sentinel_value_approach#444vincent-herlemont wants to merge 1 commit into
vincent-herlemont wants to merge 1 commit into
Conversation
…oach - Replace NaiveDate with DateTime<Utc> wrapper for better precision and ordering - Add DateTimeWrapper struct implementing ToKey trait using timestamp_millis() - Create SENTINEL_DATE_TIMESTAMP constant and create_sentinel_date() helper - Update test data to use DateTime values with proper timestamps - Demonstrate queryable date/time "null" values using sentinel pattern - Follows the chrono DateTime example pattern from the codebase documentation This enables efficient querying of date/time fields even when representing "no date" values, avoiding the limitations of Option<T> fields in indexes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
timestamp_millis()methodBenefits
Test Results
All tests pass, including the enhanced
test_sentinel_value_approachthat now covers: