Skip to content

change visual background in quiet colorscheme (for dark background)#298

Open
chrnz008 wants to merge 3 commits into
vim:masterfrom
chrnz008:quietweak
Open

change visual background in quiet colorscheme (for dark background)#298
chrnz008 wants to merge 3 commits into
vim:masterfrom
chrnz008:quietweak

Conversation

@chrnz008

@chrnz008 chrnz008 commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

in darkbackground of quiet colorscheme the visual selection looks like this
Screenshot 2026-03-28 114353
it also makes it hard to see if it extends till whitespace
Screenshot 2026-03-28 114416
change the background to white to make it look better
Screenshot 2026-03-28 114437
this issue only occurs in gvim because cursor color is not defined (either we can define cursor color or change the visual highlights)

@chrnz008

chrnz008 commented Mar 28, 2026

Copy link
Copy Markdown
Contributor Author

simmilar thing appears in cursearch too!! i think it better to just change the cursor color in darkmode

@lifepillar

lifepillar commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

IIUC, the issue is the cursor's visibility? To me, Visual looks good as it is currently. White on yellow doesn't make it better as it has less contrast (maybe too low contrast: you may check Colortemplate's stats).

The reverse cursor in Visual mode is admittedly not ideal when the cursor is at one end of the visual selection. I personally have it blinking, so it's not a big deal.

How about setting Cursor white black reverse?

@chrnz008

chrnz008 commented Mar 28, 2026

Copy link
Copy Markdown
Contributor Author

How about setting Cursor white black reverse?

Yeah I reverted the prev commit and did the same thing
and i think it is better to fix the cursor color in light mode too (even though it isn't a issue)

@chrnz008

Copy link
Copy Markdown
Contributor Author

@lifepillar looks like the cursor is just not white or black it is inheriting the color from Normal so it is better if we change them

@habamax

habamax commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

This needs @neutaaaaan review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants