[WIP] Add missing test coverage#7
Closed
sean-george-anchor wants to merge 1 commit into
Closed
Conversation
Remediate all HIGH/MEDIUM/LOW findings from the security audit: - Add sync.Mutex to Queue for concurrent map access safety (vikstrous#1) - Remove hardcoded 10s activity timeout from WithImplementation (vikstrous#2) - Remove debug fmt.Println leaking workflow IDs (vikstrous#3) - Add validateName to all constructors, panic on empty names (vikstrous#4) - Add nil client check in NewFromSDK (vikstrous#5) - Fix %s to %w for proper error wrapping in replaytest (vikstrous#6) - Fix "activtity" typo and wrong noun in error messages (vikstrous#7) - Fix goroutine leak in Worker.Run with done channel pattern (vikstrous#8) - Change mock stubs from panic to error return (vikstrous#19) Add 39 tests across 8 files bringing root package from 0% to 49% coverage. Remaining uncovered code requires a live Temporal server.
Contributor
Author
|
this needs cleaning up, but I need to bounce |
sean-george-anchor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediate all HIGH/MEDIUM/LOW findings from the security audit:
Add 39 tests across 8 files bringing root package from 0% to 49%
coverage. Remaining uncovered code requires a live Temporal server.