Skip to content

fix(appshell): move openSource useCallback above conditional returns #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikranthreddimasu merged 1 commit into from
Apr 18, 2026
Merged

fix(appshell): move openSource useCallback above conditional returns #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 29 additions & 20 deletions apps/desktop/src/components/layout/AppShell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,35 @@ export function AppShell() {
e.target.value = '';
};

// Single entry point for opening a source — called from both the source
// panel card click and citation marker click in MessageBubble. Declared
// BEFORE the conditional early returns below so hook order stays stable
// across wizard/welcome/main renders (Rules of Hooks).
const openSource = useCallback(
async (source: SourceChunk) => {
const notebookId = source.notebook_id || activeNotebookId;
if (!notebookId) return;
try {
const url = await getDocumentPreviewUrl(notebookId, source.source_path);
const filename =
source.document_name ||
source.source_path.split(/[/\\]/).pop() ||
source.source_path;
setResolvedPreviewUrl(url);
setHighlightText(source.preview);
setPreviewDocument({
filename,
source_path: source.source_path,
chunk_count: 0,
preview: '',
});
} catch {
showToast('Could not open source', 'error');
}
},
[activeNotebookId, setPreviewDocument],
);

// Show wizard overlay
if (showWizard) {
return (
Expand Down Expand Up @@ -241,26 +270,6 @@ export function AppShell() {
);
}

// Single entry point for opening a source — called from both the source
// panel card click and citation marker click in MessageBubble. Keeps the
// fetch/open/highlight dance in one place.
const openSource = useCallback(
async (source: SourceChunk) => {
const notebookId = source.notebook_id || activeNotebookId;
if (!notebookId) return;
try {
const url = await getDocumentPreviewUrl(notebookId, source.source_path);
const filename = source.document_name || source.source_path.split(/[/\\]/).pop() || source.source_path;
setResolvedPreviewUrl(url);
setHighlightText(source.preview);
setPreviewDocument({ filename, source_path: source.source_path, chunk_count: 0, preview: '' });
} catch {
showToast('Could not open source', 'error');
}
},
[activeNotebookId, setPreviewDocument],
);

return (
<>
<div
Expand Down
Loading