Skip to content

refactor: upgrade php to 8.1 and thecodingmachine/safe to 3#3

Merged
victor-teles merged 9 commits into
mainfrom
feature/upgrade-dependencies
May 2, 2026
Merged

refactor: upgrade php to 8.1 and thecodingmachine/safe to 3#3
victor-teles merged 9 commits into
mainfrom
feature/upgrade-dependencies

Conversation

@victor-teles
Copy link
Copy Markdown
Owner

@victor-teles victor-teles commented May 2, 2026

Closes #2


Summary by cubic

Raise minimum PHP to 8.2 and bump thecodingmachine/safe to v3. CI now tests PHP 8.2–8.4, uses Node 24 via actions/setup-node@v6, disables fail-fast, and simplifies Composer/npm installs with caching and Playwright setup for faster, stable runs.

  • Dependencies
    • Dev: upgrade phpstan/phpstan to ^2.0 and thecodingmachine/phpstan-safe-rule to ^1.4
    • Update @zoon/rialto to 1.6.6
    • Refresh composer.lock

Written for commit 5cd839b. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/tests.yaml">

<violation number="1" location=".github/workflows/tests.yaml:43">
P2: Avoid falling back to `npm install` after `npm ci` fails; this can mask lockfile integrity problems and make CI run with non-locked dependencies.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread .github/workflows/tests.yaml Outdated
victor-teles and others added 2 commits May 2, 2026 09:07
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@victor-teles victor-teles merged commit 68c9442 into main May 2, 2026
7 checks passed
@victor-teles victor-teles deleted the feature/upgrade-dependencies branch May 2, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency thecodingmachine/safe v2.5 is causing unnecessary log overload due to deprecation in php 8.4

1 participant