Skip to content

gazebo-setup, part-1: fix docker logs command and correct expected startup messages#5088

Open
ya8282 wants to merge 5 commits into
viamrobotics:mainfrom
ya8282:fix/gazebo-setup-docker-logs-follow
Open

gazebo-setup, part-1: fix docker logs command and correct expected startup messages#5088
ya8282 wants to merge 5 commits into
viamrobotics:mainfrom
ya8282:fix/gazebo-setup-docker-logs-follow

Conversation

@ya8282

@ya8282 ya8282 commented Jun 3, 2026

Copy link
Copy Markdown

Summary

Note

This discrepancy could be a candidate for a Docker smoke-test in CI. Something like:

smoke-test:
  needs: build-and-push-local
  runs-on: ubuntu-latest
  steps:
    - uses: docker/login-action@v3
      # pull the image just built
    - run: |
        docker run -d --name smoke-test ghcr.io/viamrobotics/can-inspection-simulation:latest-local
        docker logs -f smoke-test 2>&1 | grep -m 1 "viam-server entered RUNNING state"
      timeout-minutes: 3

Two related fixes for the can inspection simulation setup flow.

gazebo-setup.md — Step 5: Verify the Setup

The docker logs command shown requires the user to run it repeatedly to catch the startup message. Replaces it with docker logs -f to stream output in real time, and corrects the expected log messages — the string "Can Inspection Station 1 Running!" does not appear in the actual container output.

Also renames View logs to Follow logs in the Container Management section to match Docker's terminology for the -f/--follow flag.

Before:
```
docker logs gz-station1

Look for:

  • "Can Inspection Station 1 Running!"
  • viam-server startup messages
    ```

After:
```
docker logs -f gz-station1

Wait for the following messages, then press Ctrl+C:

  • can-spawner entered RUNNING state
  • web-viewer entered RUNNING state
  • viam-server entered RUNNING state
    ```

part-1.md — Prerequisites

Updates the same incorrect log message reference in the prerequisites section.

Before:

Once you see "Can Inspection Simulation Running!" in the container logs...

After:

Once the container logs show can-spawner, web-viewer, and viam-server each entered RUNNING state...

Verification

Log output confirming the correct messages (truncated):
```
2026-06-03 22:07:41,707 INFO success: can-spawner entered RUNNING state, process has stayed up for > than 15 seconds (startsecs)
2026-06-03 22:07:41,707 INFO success: web-viewer entered RUNNING state, process has stayed up for > than 15 seconds (startsecs)
2026-06-03 22:07:41,708 INFO success: viam-server entered RUNNING state, process has stayed up for > than 15 seconds (startsecs)
```

🤖 Generated with Claude Code

@netlify

netlify Bot commented Jun 3, 2026

Copy link
Copy Markdown

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit ac5d214
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/6a20aaeffb6ca10009a4e239
😎 Deploy Preview https://deploy-preview-5088--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 43 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant

CLAassistant commented Jun 3, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@viambot

viambot commented Jun 3, 2026

Copy link
Copy Markdown
Member

👋 Thanks for contributing! A reviewer will look at it on the next working day!

@ya8282 ya8282 marked this pull request as ready for review June 3, 2026 22:31
@10zingpd 10zingpd requested a review from shannonbradshaw June 8, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants