Update ICE server docs for signaling-provided config#5064
Open
shannonbradshaw wants to merge 1 commit into
Open
Update ICE server docs for signaling-provided config#5064shannonbradshaw wants to merge 1 commit into
shannonbradshaw wants to merge 1 commit into
Conversation
The RDK no longer hardcodes a default Twilio STUN server for WebRTC connections. ICE servers are now provided by the signaling server during the handshake. Update the connection model page to reflect the current behavior. https://claude.ai/code/session_01A7cWYC17gfsc8w7vLx82q7
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
viambot
added
the
safe to build
|
Hey @shannonbradshaw — CI is green and no reviewer is assigned yet. Could you request one when you have a chance? Auto-comment from overwatch. Will not re-nudge for 7 days. |
2 similar comments
|
Hey @shannonbradshaw — CI is green and no reviewer is assigned yet. Could you request one when you have a chance? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey @shannonbradshaw — CI is green and no reviewer is assigned yet. Could you request one when you have a chance? Auto-comment from overwatch. Will not re-nudge for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source changes
grpc/webrtc.gowhich hardcoded Twilio's public STUN server (stun:global.stun.twilio.com:3478) as the default WebRTC ICE configuration. Both the client dialer (grpc/dial.go) and the server (robot/web/web.go) now use zero-value WebRTC options, relying on the signaling server to provide ICE server configuration during the handshake.Docs changes
docs/build-apps/concepts/how-apps-connect.md: Removed the incorrect claim that the SDK defaults to Twilio's public STUN server. Replaced with accurate description that the signaling server provides ICE server configuration during the WebRTC handshake.How I found these
stun:global.stun.twilio.commatched 1 file,ICE servermatched 1 file,DefaultWebRTCConfigurationmatched 0 files in docsGenerated by daily docs change agent
Generated by Claude Code