Skip to content

RSDK-14032 - update viam-cpp-sdk to v38#211

Merged
nfranczak merged 5 commits into
viam-modules:mainfrom
nfranczak:20260528-RSDK-14032-update-cpp-sdk
Jun 8, 2026
Merged

RSDK-14032 - update viam-cpp-sdk to v38#211
nfranczak merged 5 commits into
viam-modules:mainfrom
nfranczak:20260528-RSDK-14032-update-cpp-sdk

Conversation

@nfranczak

Copy link
Copy Markdown
Contributor

No description provided.

@nfranczak nfranczak requested a review from acmorrow May 28, 2026 16:13
Comment thread CMakeLists.txt Outdated
@nfranczak nfranczak requested a review from acmorrow May 28, 2026 16:19

@acmorrow acmorrow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, please do not merge this yet. We should land #209 first so we can tag it as 0.6.1. If we do it the other way around, 0.6.1 won't build because the docker image will be too new for it.

@acmorrow

Copy link
Copy Markdown
Contributor

@nfranczak -

We are going to address the pinning issue by way of #212. We will land that first, then #209. That will set us up for an 0.6.1-rc1 that is reproducible.

Then, we will handle #211. That will need to get split into two commits: an update to the docker file, which will trigger a docker rebuild, and then the main commit which upgrades TO the new docker file. I'lll leave more comments on #211

@acmorrow

Copy link
Copy Markdown
Contributor

I'lll leave more comments on #211

Lol this is #211. Moving too fast ...

Anyway, here is what should be done. Once we have #212 and #209 landed, then this PR should be split.

  1. Pull out ONLY the Dockerfile changes into a new PR. I'll instantly approve it, and you can merge.
  2. Wait for CI to build and push the new Docker images.
  3. Remove the Dockerfile changes from this PR. CI should fail, because the pinned Docker image is out of date.
  4. Update the SHAs in this PR to use the new images.
  5. Confirm CI now passes.

Then we can merge this safely, and everything after #212 will now be reproducible in CI.

Comment thread Dockerfile Outdated
RUN cd /root/opt/src && \
git clone https://github.com/viamrobotics/viam-cpp-sdk && \
cd viam-cpp-sdk && \
git checkout releases/v0.31.0 && \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this out into a new, standalone PR, rebased above the commit from #212.

@nfranczak nfranczak changed the title RSDK-14032 - update viam-cpp-sdk to v37 RSDK-14032 - update viam-cpp-sdk to v38 Jun 8, 2026
@nfranczak nfranczak requested a review from acmorrow June 8, 2026 20:39

@acmorrow acmorrow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@nfranczak nfranczak merged commit b311ad5 into viam-modules:main Jun 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants