RSDK-14053 Add Conversation timeout attribute #23
Merged
Merged
Conversation
seanavery
reviewed
Jun 3, 2026
| speech_segment.speech_chunk_buffer.append(audio_chunk) | ||
| speech_segment.speech_buffer.extend(frame) | ||
|
|
||
| match (state, is_speech): |
There was a problem hiding this comment.
Is this new python syntax? Do we need to update anything in pyinstaller or CI to make sure we are building with newer python ver?
Collaborator
Author
There was a problem hiding this comment.
needs python 3.10+, ill update setup.sh to make that explicit
| self.detection_engine == "openwakeword" | ||
| and self._in_conversation_window() | ||
| ): | ||
| speech_segment.oww_detected = True |
There was a problem hiding this comment.
Do we need min_speech_frames check on the oww path?
Collaborator
Author
There was a problem hiding this comment.
min_speech_frames in only meaningful for vosk, meant to avoid running inference on speech segments that are too small
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversation_timeout_secondsconfig attribute. After a wake word fires and a segment is yielded, any speech that begins within this window streams through without requiring the wake word again — letting users ask follow-up questions naturally._run_detection).0(disabled) — module behaves as a strict wake-word filter when not configured.Implementation
_in_conversation_window()/_refresh_conversation_window()helpers usingtime.monotonic()._process_vad_frameat IDLE→ACTIVE to setoww_detected = Truedirectly, so the existing streaming path engages without an OWW inference hit._run_detectionto yield buffered chunks + sentinel unconditionally during the window.Testing