Skip to content

Forms design update#180

Open
r0ms wants to merge 12 commits into
masterfrom
forms
Open

Forms design update#180
r0ms wants to merge 12 commits into
masterfrom
forms

Conversation

@r0ms

@r0ms r0ms commented Jul 28, 2015

Copy link
Copy Markdown
Contributor

Here are the new forms for tetra.
Concerning misplacement of icons, it came from the fact that I had to zoom out to take thoses screenshot ;)

capture d ecran 2015-07-28 a 10 21 15

capture d ecran 2015-07-28 a 10 21 31

capture d ecran 2015-07-28 a 10 21 40

capture d ecran 2015-07-28 a 10 21 50

capture d ecran 2015-07-28 a 10 21 58

capture d ecran 2015-07-28 a 10 22 11

capture d ecran 2015-07-28 a 10 22 21

capture d ecran 2015-07-28 a 10 22 31

@tregagnon

Copy link
Copy Markdown
Contributor

I think the code used for the input with the help icon (the checkmark or the cross) should be changed.

The image is absolutely positioned above the input. It hides buttons added by Operating Systems to clear the input. IE11 adds a cross to clear the input, inside the input, where the icons are located. If I remember well, Safari also does it with search inputs.

I think we should try to achieve the same effect, but using the same technique than input-append. The icon would be next to the input element, so it will not hide the input's content, but visually would seem to be in the input.

@r0ms

r0ms commented Jul 31, 2015

Copy link
Copy Markdown
Contributor Author

Good point and never thought of it when I was developping these changes.
From my point of view, these icons should be positiones outside. If on some browser (and I guess major browser), a default icon is added, having a double icon could be disturbing for the user.

@tregagnon tregagnon changed the title Forms Forms design update Aug 3, 2015
@r0ms

r0ms commented Feb 15, 2016

Copy link
Copy Markdown
Contributor Author

Done! This time we use almost the same technique than input-append (because it's not a btn but a simple div) for input with icons.
This branch looks forward to be merged but there is a LOT of conflicts with the last release...

@CarAuto34

Copy link
Copy Markdown

Ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants