Make position indexing work more similarly across implementations#241
Merged
Conversation
…ss they can do most operations on unindexed paths
Member
Author
|
I need to regenerate the bindings in order to merge this. |
We now use a much newer LLVM which can accept current MacOS headers. We also bump the C++ standard to C++17 because the hopscotch-map headers use std::launder which is not available until C++17.
…static and instance methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
PositionOverlay,MutablePositionOverlay,ReferencePathOverlay,PackedPositionOverlay, andPackedReferencePathOverlaywork more similarly.Now they all look at REFERENCE and GENERIC-sense paths by default, and can be told to look at other paths in a similar way.
Some of them completely hide the un-indexed paths, and others raise exceptions when trying to do operations on paths that would need the index when they aren't indexed, but both of those behaviors are now under test.
This is related to #236 and #237.