Hublabel#239
Open
electricEpilith wants to merge 116 commits into
Open
Conversation
…it returns, and which is a different size on mac
…rs that validate it
…opefully query off the right orientations
…ses that all can run
…rtices from a net graph child. Add a bunch of comments exlaining why I am confused by the distance index orientation bookkeeping.
…ord access attempts
…t that instead of unpicking it
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix by GPT-5 mini thru GitHub Copilot
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adamnovak
requested changes
Jun 1, 2026
adamnovak
left a comment
adamnovak
left a comment
Member
There was a problem hiding this comment.
This looks pretty good, but there are still some fairly big functions that are neither called nor documented (and appear to be removable), and it looks like something went wrong with an attempt to add doc comments by find-and-replace which probably needs to be cleaned up.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The committed Binder-generated bindings had drifted from the headers and no
longer compiled:
- is_regular_snarl was simplified to a single (const net_handle_t&) overload,
but the bindings still referenced the removed 2-arg/3-arg forms.
- get_start_endpoint/get_end_endpoint now return endpoint_t (not const), but
the bindings cast to const endpoint_t.
Regenerated all bindings with make_and_run_binder.py. To make regeneration work
again on this branch:
- Add the Homebrew include dir to Binder's clang invocation so it can find
Boost (where CMake's find_package(Boost) locates it).
- Mark bdsg/ch.hpp (contraction hierarchy, C++20 + Boost Graph) BINDER_IGNORE
so Binder skips it. It was never bound and cannot be cleanly auto-bound;
its Boost/<ranges> includes and #include sites are ignored.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libbdsg changes to go with merging the hublabel branch of vg