[systemlag] Lag id boundary set for system lag#3
Open
vganesan-nokia wants to merge 103 commits into
Open
Conversation
vganesan-nokia
force-pushed
the
voq-system-lag-2
branch
from
January 18, 2021 20:49
be16a26 to
d0c2991
Compare
vganesan-nokia
force-pushed
the
voq-system-lag-2
branch
from
February 10, 2021 16:41
d0c2991 to
1214d9c
Compare
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
2 times, most recently
from
February 17, 2021 19:32
fa47d32 to
b513a1e
Compare
Update FRR 7.5 head. The following is a list of new commits. ``` e2f17ae47ad047e66923c2ff1e84c9ba10d4ad38 Merge pull request sonic-net#8096 from idryzhov/7.5-backports-2021-02-16 380341362ced8e317c18b7395acb012de1f23acd ospf6d: Don't send hellos on loopback interface 7fa78b659f8e720466e0df62689327ea4b9ff867 bgpd: send correct BMP down message when nht fails 385faf6c079a41def1e6eb882cbfd50047559644 [filter]: change return code for errors d9a0e9a2934f2f75c64496fe4c724a18aa581fcb bfdd: fix session lookup 08afa0a75311a4e8cb2a18116384b603f7f2d751 ospf6d : fix issue in ecmp inter area route 2299afa1a9128d87d5169742b993c0ada575eb83 ospfd: Prevent duplicate packet read in certain vrf situations ff42a28af659ee61c0efb877b10738a5812f4bc2 vrf: use wrappers to change VRF_CONFIGURED flag 2bdc59ca21da2d67b77ec70a2fadffbca60690cd vrf: mark vrf as configured when entering vrf node b9611f65a71adc0b8fa14a5a4d1a8f44e04dcd85 ospf6d: Fix LSA formatting out-of-bounds access 610ebf56913fa56167b0a2a127b07afe020a1efe bfdd: Prevent use after free ( again ) 35b0cd5d753dda9aa70ea1c06db61a8d4b8671e3 *: Fix usage of bfd_adj_event 95b8915d0f4de3eae5438632ecd0827061ef48e8 ospf6d: Fix LSA formatting inconsistent retvals 49d73d8be84dbd23d767697474019165e511786c pimd: SGRpt prune received during prune didn't override holdtime 1d0d19afa9bb7cd4bc476d00c887876bc04eee95 eigrpd: Correctly set the mtu for eigrp packets sent bbb08db69f8eb554d23b4920c1c1e3982d8d2a91 zebra: Prevent sending of unininted data 0813d650a8120458ab7d9317061f3864dbc6f2f7 ospf6d: prevent use after free 2f2e981d967b36b240fca82fea8a961d927ef43c lib: Prevent unininted usage of data 6171becdb391ea5b88916a3a28b04b555e1fc518 bfdd: Prevent storage of ifp pointer that has been deleted 9ebb41cf4bb51e0872796530bf8c7a4d819053db bfdd: Prevent unininited data transmittal 72e16db6fea3629111537f9eb10c86f2d275adcb eigrpd: Prevent uninitialized value from being used 72b61a5bb09d59c3cc0d1d401d51de96949dff52 zebra: disallow resolution to duplicate nexthops 1083bae40b00c0ed2c9f3521ae1ab9675a87202e bgpd: Initialize bgp_notify.raw_data before passing to bgp_notify_receive() 31df7314310416f10c133dcfe9c4586edadf3fbb doc: ebgp-requires-policy requires manuall session clearing ecc8ec678d2d8a1c3d1d50a22732f9fc4bad689c watchfrr: fix SA warning 9d9365d161979a031de817c1fbcab6508dfee013 watchfrr: fix crash on missing optional argument 907e600d63c1c5b6bda40b0a08344a72533b1787 pimd: Prevent use after free b47374f0e95d99c93bfe2d14afe55219a9fda455 doc: Update bgp doc for more rfc-8212 talk 4fbeef60cc8dc5362ff84fc91d1a4e343e4e32c7 docker: centos 7, 8 yang bump and repo fixes 808e6d731f330df4a91fdfd6df6a3c8dce1651a6 docker: prefer alpine:latest for building 91b3c471f1c48818370a0f218add917f0d46aa47 Merge pull request sonic-net#8092 from donaldsharp/7.5_track 60be43c0bf63c16ca42008fa802d0a2050f3fce2 Merge pull request sonic-net#8090 from ton31337/fix/static_network_vrf_7.5 1f6785aa60cc57a5c8d5de98c9c09a344a0c9262 ospf6d: Track wait_timer and disable when needed c89e326be91312bed066eb2447ea8944e25a225e bgpd: Check for peer->su_remote if not NULL when handling IPv6 nexthop 15e070f6448870c98c030b6b5013ad8750d8918b Merge pull request sonic-net#8047 from pguibert6WIND/nhrp_shortcut_routes_75 912994efec94082ae7d8c5e014c410964bea19f4 Merge pull request sonic-net#8034 from qlyoung/fix-gnu-readline-bracketed-paste-7.5.1 9f50536993f1eb900fbfbe98d21b8c072bbd9c15 nhrpd: replace nhrp route nexthop with onlink route when prefix=nh 8c185008246db31c34574d7b79358001ac411f84 nhrpd: shortcut routes installed with nexthop. c46c87d19758040bc3f3902ab8e4a0f1bb908721 vtysh: disable bracketed paste in readline 20b35e4c3386de798f3b0cb9f2a7e6b04d995485 Merge pull request sonic-net#8018 from ton31337/fix/drop_aggregate_as_attribute_if_malformed_7.5 fa25d7327fd64613cc7530aba2edfcde038da074 bgpd: Unset only aggregator flag when AGGREGATOR_AS is 0 3ee9a3726fe1a526d946c1978487a4509fe98f29 bgpd: Drop aggregator_as attribute if malformed in case of BGP_AS_ZERO be88595c6a2011f0e882bfa663baa61c86ede14e Merge pull request sonic-net#8005 from opensourcerouting/snap-libyang1-fix-75 fd840ad37f2e836b210c6e60fc6325a4c3e495ce snapcraft: Update rtrlib to 0.7.0 3d00552fa9aedb96acd7ea773bc14fd2b77e7e0f snapcraft: Fix passthrough path for Libyang 1.x ```
This PR includes the following commit in sonic-platform-daemons 068bccc [xcvrd] Store mux_cable telemetry data in State DB (sonic-net#148) 93cac0a [ci]: download from sonic-buildimage.vs artifact (sonic-net#152) d651e9b [GitHub] Add pull request template (sonic-net#151) bd7830b [pcied] Remove unnecessary message and move the configuration path (sonic-net#144) 9080fda [ci] Call pip2/3 using sudo (sonic-net#150) de60784 [ci] Test and build packages using Azure Pipelines (sonic-net#149) 8bf0fd1 [ledd] Refactor to allow for more thorough unit testing; Increase unit test coverage (sonic-net#147) 26bdc9e Set up CI with Azure Pipelines 1fcaa57 [pcied] Add PCIe AER stats collection (sonic-net#100) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Open ACL Outer VLAN ID for egress for ports part of VLAN RIF - Why I did it Open ACL Outer VLAN ID for egress for ports part of VLAN RIF - How I did it Updated SAI submodule pointer - How to verify it Build an image, deploy and check all is up and running. Verify ACL sonic-mgmt test is passing Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
- Why I did it Mellanox-SN4600C-D112C8 SKU is not configured properly. It should have 112 50G interfaces and 8 100G interfaces as described on this PR. - How I did it Modify sai_profile, port_config.ini and hwsku.json for DPB. - How to verify it Apply this HwSKU to a MSN4600C Mellanox platform. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Change in this update:
b75aab7 [swss-common] Add LINKMGR CFG and MUX LINKMGR state table names (sonic-net#421)
4a77d1c [ci]: add vstest (sonic-net#459)
07258a6 [ci]: use build template (sonic-net#457)
ddcae3e runRedisScript api to process integer returned by script run in the redis (sonic-net#447)
33d89c7 [systemlag] Schema defs for system lag (sonic-net#448)
af01f37 spell check fixes (sonic-net#456)
7afd43d Update to make getNamespaces() API at par with the get_ns_list() swssdk-py API. (sonic-net#455)
signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
…raph (sonic-net#6219) Update topology script to retrieve hwsku from minigraph if hwsku information is not available in config_db. Fix clean up of interfaces in msft_multi_asic_vs hwsku topology script. - Why I did it When bringing up multi-asic VS switch, topology service is started during boot up. Topology service starts a shell script which runs the topology script present in /usr/share/sonic/device// directory. To invoke hwsku specific script, the topology script tries to retrieve hwsku information from config_db. During initial boot up config_db might not be populated. In order to start topology service before config_db is updated, update topology script to get hwsku information from minigraph.xml if it is available. This will be helpful to bring up multi-asic VS testbed by loading minigraph and starting topology service. - How I did it Update topology.sh script to retrieve hwsku information from minigraph.xml. Fix clean up function on msft_multi_asic_vs toplogy script. - How to verify it single-asic VS - no change; topology service is only enabled for multi-asic VS. multi-asic VS - Bring up multi-asic VS image, copy minigraph to vs image, start topology service. Topology service should be successful. to test clean up function fix, start topology service - make sure interfaces are created and moved to the right namespaces. stop topology service - make sure namespace do not have any interface and all front end interfaces are present in default namespace.
- Add support for `DCS-7050SX3-48YC8` and `DCS-7050SX3-48C8` platform - Add support for more variants of `DCS-7280CR3-32[PD]4` - Add Supervisor to Linecard consutil support - Complete Watchdog platform API support - Fix some PSU behavior on `DCS-7050QX-32` and `DCS-7060CX-32S` - Fix SEU management on `DCS-7060CX-32S` - Allow kernel modules to build up to linux 5.10 - Rename led color `orange` to `amber` - Miscellaneous fixes
…onic-net#6475) - Why I did it The pcie configuration file location is under plugin directory not under platform directory. sonic-net#6437 - How I did it Move all pcie.yaml configuration file from plugin to platform directory. Remove unnecessary timer to start pcie-check.service Move pcie-check.service to sonic-host-services - How to verify it Verify on the device
sonic-net#6833) It is possible that one interface attaches multiple vlans. The VlanInterface should be in tagged mode. Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
Set correct MTU size of internal interface for Newport platform
Needed support for platform system health in Dell platforms
#### Why I did it Fix runtime issues caused by SONiC update #### How I did it - new attribute SAI_ACL_ENTRY_ATTR_FIELD_ACL_IP_TYPE supported - new attribute SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY supported Signed-off-by: Roman Savchuk <romanx.savchuk@intel.com>
show ip interfaces is enhanced recently to support multi ASIC platforms in this PR- sonic-net/sonic-utilities#1396 . The ipintutil script as to run as sudo user, to get the ip interface from each namespace. Add this script to the sudoer file so that show ip interface command is available for user with read-only permissions Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
- Improve sonic-mgmt platform test suite pass rate - Improve coverage of platform unit tests - Provide platform specific reboot logic as per platform porting guide - Fix bug due to pcie.yaml file being located in the wrong directory
183162f Fix issue: expect redis pubsub data to be str type instead of bytes type (sonic-net#196) #### Why I did it Update submodule pointer for snmpagent to include PR sonic-net/sonic-snmpagent#196 #### How I did it Update submodule pointer for snmpagent #### How to verify it Run build
To fix sonic-net#6860 Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
1. Add supervisord as the entrypoint of docker-macsec
2. Add wpa_supplicant conf into docker-macsec
3. Set the macsecmgrd as the critical_process
4. Configure supervisor to monitor macsecmgrd
5. Set macsec in the features list
6. Add config variable `INCLUDE_MACSEC`
7. Add macsec.service
**- How to verify it**
Change the `/etc/sonic/config_db.json` as follow
```
{
"PORT": {
"Ethernet0": {
...
"macsec": "test"
}
}
...
"MACSEC_PROFILE": {
"test": {
"priority": 64,
"cipher_suite": "GCM-AES-128",
"primary_cak": "0123456789ABCDEF0123456789ABCDEF",
"primary_ckn": "6162636465666768696A6B6C6D6E6F707172737475767778797A303132333435",
"policy": "security"
}
}
}
```
To execute `sudo config reload -y`, We should find the following new items were inserted in app_db of redis
```
127.0.0.1:6379> keys *MAC*
1) "MACSEC_EGRESS_SC_TABLE:Ethernet0:72152375678227538"
2) "MACSEC_PORT_TABLE:Ethernet0"
127.0.0.1:6379> hgetall "MACSEC_EGRESS_SC_TABLE:Ethernet0:72152375678227538"
1) "ssci"
2) ""
3) "encoding_an"
4) "0"
127.0.0.1:6379> hgetall "MACSEC_PORT_TABLE:Ethernet0"
1) "enable"
2) "false"
3) "cipher_suite"
4) "GCM-AES-128"
5) "enable_protect"
6) "true"
7) "enable_encrypt"
8) "true"
9) "enable_replay_protect"
10) "false"
11) "replay_window"
12) "0"
```
Signed-off-by: Ze Gan <ganze718@gmail.com>
* remove trailing / from url for submodule "platform/mellanox/hw-management/hw-mgmt" Signed-off-by: Don Newton don@opennetworking.org
…net#6558) - Why I did it Current mutli-asic vs hwsku consists of 6 asics with each asic having 32 interfaces. When bringing this up, below issue was seen: When all 32 interfaces(sonic interfaces and linux interface) are set to 9100 mtu, DMA error is seen "DMA: Out of SW-IOMMU space for 4096 bytes at device 0000:06:03.0" which can be fixed by updating swiotlb=65536 in /host/grub/grub.cfg .In order to keep multi-asic VS lighter and easier to bring up and test, new hwsku 'msft_four_asic_vs' is added to represent 4-asic hwsku with 2 frontend asics and 2 backend asics and each asic having 8 interfaces interconnected by port-channels. - How I did it Add msft_four_asic_hwsku directory to have the right number of directories (4) and update port_config.ini and lanemap.ini files to include 8 ports information. Add topology.sh script to create the internal asic-asic connectivity. - How to verify it Update asic.conf with the 4 asic information as below and build sonic-vs.img: NUM_ASIC=4 DEV_ID_ASIC_0=0 DEV_ID_ASIC_1=1 DEV_ID_ASIC_2=2 DEV_ID_ASIC_3=3 Modify sonic_multiasic.xml to have 8 front panel interfaces. create virtual switch using "sudo virsh sonic_mutliasic.xml" command. Start topology service and Load config_db files for switch and each asic. Ensure that that all internal interfaces and port_channels are coming up. multi-asic vs testbed: Bring up mutli-asic VS testbed with a multi-asic image(asic.conf updated to 4 asics) and using t1-lag topology. ./testbed-cli.sh -t vtestbed.csv -m veos_vtb -k ceos add-topo vms-kvm-four-asic-t1-lag password.txt Load minigraph/config_dbs. Ensure all internal and external interfaces come up. No change on single asic vs.
Removed or adapted obsolete code Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
As booting on DCS-7060DX4-32 would use the default sku of DCS-7060PX4-32 which is not compatible, thus move some files around to properly separate the configurations that are device specific. Signed-off-by: Samuel Angebault <staphylo@arista.com>
…-net#6878) #### Why I did it Additional file for DPB in order to support SKU SN2700-D40C8S8 on master #### How I did it Add hwsku.json file #### How to verify it Enforce "Mellanox-SN2700-D40C8S8 SKU on Master and see it works as expected, meaning: Port 1/3 will be used as 4x10G Port 2/4 - Not exist (blocked since 1 and 3 split to 4) Port 7/8/9/10/23/24/25/26 will used as 100G All other ports will be used as 2x50G This PR should be added on top of PR: sonic-net#6876 #### Description for the changelog Adding hwsku.json file to SN2700-D40C8S8 SKU
…et#6867) Readme file should be updated with steps required to bring up multi-asic virtual switch.
…onic-net#6979) This reverts commit 7034edc.
* [Submodule] Update sonic-swss till the commit: 0b0d24c - 2021-02-04 : [Mux] Route handling based on mux status, kernel tunnel support (sonic-net#1615) [Prince Sunny]
…#6517) #### Why I did it - The xcvrd service requires an event detection function, unplug or plug in the transceiver. #### How I did it - Add sysfs interrupt to notify userspace app of external interrupt - Implement get_change_event() in chassis api. - Also begin installing Python 3 sonic-platform package for Celestica platforms
Includes the following commits: 1673d25 [y_cable] refactor upgrade firmware API's; Fix vendor and part number API's read size for read_eeprom (sonic-net#174) ed93a15 [sonic_platform_base] Proper use of class and instance attributes (sonic-net#173) 691de92 [sonic_y_cable] add stub function for upgrade firmware of Y cable and split the get_part_number and get_vendor API's (sonic-net#171) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
- Why I did it
To collect platform based logs along with "show techsupport" on S6000 and S6100 plaforms.
- How I did it
On branch dell_techsupport_dump
Changes to be committed:
(use "git reset HEAD ..." to unstage)
new file: platform/broadcom/sonic-platform-modules-dell/common/actions.sh
modified: platform/broadcom/sonic-platform-modules-dell/debian/platform-modules-s6000.install
modified: platform/broadcom/sonic-platform-modules-dell/debian/platform-modules-s6100.install
new file: platform/broadcom/sonic-platform-modules-dell/s6000/scripts/hw-management-generate-dump.sh
new file: platform/broadcom/sonic-platform-modules-dell/s6100/scripts/hw-management-generate-dump.sh
- How to verify it
hw-mgmt-dump.tar.gz will be found in sonic_dump__< YYYYMMDD_HHMMSS>.tar.gz.
…net#6990) * include all vlan intf into downstream intf * add a comment
…c-net#6999) ref: https://bootstrap.pypa.io/2.7/get-pip.py The URL you are using to fetch this script has changed, and this one will no longer work. Please use get-pip.py from the following URL instead: https://bootstrap.pypa.io/pip/2.7/get-pip.py
…onic-net#6637) Changes: — Remove unnecessary file libyang-python-tests/sample_config_db.json — Keep only config in format of sonic_yang.json in yang_model_tests/yangTest.json. — Keep config in format of config_db.json in file tests/files/sample_config_db.json — Add a test case to validate yang models. **- Why I did it** As per discussion in sonic Yang workgroup, arranging files better so that Yang model can be in force for new config, also adding a test case to validate young models upto some extent. **- How I did it** Changes: — Remove unnecessary file libyang-python-tests/sample_config_db.json — Keep only config in format of sonic_yang.json in yang_model_tests/yangTest.json. — Keep config in format of config_db.json in file tests/files/sample_config_db.json — Add a test case to validate yang models. **- How to verify it** Build PKGs----Building-----
…et#6985) Why I did it We skip install of CNI plugin, as we don't need. But this leaves node in "not ready" state, upon joining master. To fix, we copy this dummy .conf file in /etc/cni/net.d How I did it Keep this file in /usr/share/sonic/templates and copy to /etc/cni/net.d upon joining k8s master. How to verify it Upon configuring master-IP and enable join, watch node join and move to ready state. You may verify using kubectl get nodes command
This package was outdated and did not properly install on buster due to dependency changes. This version should work on all DCS-7280CR3*-32[PD]4 platforms. Signed-off-by: Samuel Angebault <staphylo@arista.com>
this PR updates the following commits in sonic-utilities 13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (sonic-net#1467) f78e7ce [acl-loader] Improve input validation for acl_loader (sonic-net#1479) 748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368) 64604db [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475) 10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465) 10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470) 38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469) e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (sonic-net#1380) 4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471) dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460) e32b5ac Add soft-reboot reboot type (sonic-net#1453) 8b3bc18 [reload] Improve reload by using sonic.target. (sonic-net#1199) 99673bc [reboot] Add platform-specific reboot cause update hook (sonic-net#1454) 2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445) 1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (sonic-net#1416) 79ccd03 [show] cli support for show muxcable cableinfo (sonic-net#1448) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
…sing sudo. (sonic-net#7002) Closes issue sonic-net#6982. The issue was root caused as we were using the unix_socket for reading from DB as a default mechanism (sonic-net#5250). The redis unix socket is created as follows. admin@str--acs-1:~$ ls -lrt /var/run/redis/redis.sock srwxrw---- 1 root redis 0 Mar 6 01:57 /var/run/redis/redis.sock So it used to work fine for the user "root" or if user is part of redis group ( admin was made part of redis group by default ) Check if the user is with sudo permissions then use the redis unix socket, else fallback to tcp socket.
Signed-off-by: Ze Gan <ganze718@gmail.com>
…PI implementation and fixes (sonic-net#6988) Incorporate the below changes in DellEMC Z9332F platform: - Implemented watchdog platform API support - Implement ‘get_position_in_parent’, ‘is_replaceable’ methods for all device types - Change return type of SFP methods to match specification in sonic_platform_common/sfp_base.py - Added platform.json file in device directory. Co-authored-by: V P Subramaniam <Subramaniam_Vellalap@dell.com>
- Why I did it Update MFT tool version to 4.16.0 Bugs fixes: mlxlink: Fixed an issue that caused the margin scan to fail with the following message: Eye scan not completed. mlxcable: Cable firmware burning capability is not supported. New features: mlxlink: Enabled margin scan on Network links. mlxlink: Added PRBS TX/RX polarity inversion using the following flags: --invert_tx_polarity / --invert_rx_polarity - How I did it Update MFT make file with new version number. - How to verify it Build image and test related functions on Mellanox platform
Update FRR to 7.5.1. The following is a list of new commits. ``` df7ab485b FRRouting Release 7.5.1 f4ed841b8 Merge pull request sonic-net#8187 from opensourcerouting/rpmfixes-75 86d5a20e3 Merge pull request sonic-net#8193 from mjstapp/fix_signals_7_5 b339cc149 lib: avoid signal-handling race with event loop poll call 0f7b432c3 lib: add debug output for signal mask c0290c86d lib: add sigevent_check api 7a5348665 doc: Fix CentOS 7 Documentation 2a8e69f48 Merge pull request sonic-net#8064 from donaldsharp/foo cf4d1a744 redhat: Fix changelog incorrect date format b78dcb209 Merge pull request sonic-net#8181 from idryzhov/7.5-zebra-blackhole 2032e7e72 zebra: don't use kernel nexthops for blackhole routes e52003567 bgpd: When deleting a neighbor from a peer-group the PGNAME is optional aa86a6a6f Merge pull request sonic-net#8161 from mjstapp/fix_sa_7_5_backports 13a8efb4b Merge pull request sonic-net#8156 from idryzhov/7.5-backports-2021-02-26 58911c6ed lib: Free memory leak in error path in clippy 556dfd211 lib: use right type for wconv() return val bd9caa8f1 lib: fix some misc SA warnings 683b3fe3f lib: register dependency between control plane protocol and vrf nb nodes b45248fb6 lib: add definitions for vrf xpaths 7b9f10d04 lib: add ability to register dependencies between northbound nodes 9c240815c bgpd: Bgp peer group issue d1b43634b bgpd: upon bgp deletion, do not systematically ask to remove main bgp f5d1dc55e bgpd: Fix crash when we don't have a nexthop c2e463478 frr-reload: rpki context exiting uses exit and not end f11db1698 bgpd: Blackhole nexthops are not reachable c628e94ff staticd: fix vrf enabling 49b079ef1 staticd: fix nexthop creation and installation 0077038e9 staticd: fix nexthop validation be3dfbbc7 zebra: use AF_INET for protocol family ```
* src/sonic-platform-daemons 068bccc...e5165b7 (7): > [xcvrd] Fix crash: If 'dom_capability' not in port_info_dict, insert 'N/A' (sonic-net#162) > fix the muxcable state change notification received from other modules, omit the check inside hw_state table (sonic-net#159) > [xcvrd] Fix crash on platforms which support media settings with Python 3 (sonic-net#158) > [xcvrd] Save the dom_capability of transceiver into db (sonic-net#72) > [xcvrd] Fix xcvrd crash on other port prefixes (sonic-net#123) > [xcvrd] Make functions used for media setting python3 compatible (sonic-net#153) > [psud] Refactor unit tests; increase unit test coverage (sonic-net#146)
Why I did it sonic-mgmt-docker build was failing. How I did it pin cryptography version to 3.3.2 How to verify it build sonic-mgmt docker.
[ci] Make the title of the PR to upgrade SONiC package versions better
* 6ced42c 2021-03-11 | Revert "[config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471)" (HEAD, origin/master, origin/HEAD) [Guohan Lu] * e1c52a0 2021-03-11 | [warm-reboot]: added automated recover for ISSU file (sonic-net#1466) [Vadym Hlushko] * a4ae643 2021-03-10 | [PDDF] Remove references to deprecated platform plugins (sonic-net#1485) [fk410167] Signed-off-by: Guohan Lu <lguohan@gmail.com>
…form API (sonic-net#7018) #### Why I did it Recently, CLI sfputil replace the old sonic platform utils with sonic platform API. However, sonic platform API does not support SFP low power mode and reset related operation. The PR is to fix it. The change to replace platform utils with sonic platform API was reverted on 202012, once this PR is merged, we can cherry-pick these two PRs to 202012 together. #### How I did it In low power mode and reset related operation, use "docker exec" if the command is running on host side.
No longer install Python 2 sonic_platform package for Broadcom platforms; only install Python 3 package. Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Changes for setting platfrom specific lag id boundary id in the chassis app db. The platfrom specific lag id boundaries are supplied via chassisdb.conf. The lag_id_start and lag_id_end boundary values sourced from this file are set in chassis app db which will be used by lag id allocator to allocate unique lag id in atomic fashion
vganesan-nokia
force-pushed
the
voq-system-lag-2
branch
from
March 12, 2021 16:57
1214d9c to
58bbfce
Compare
vganesan-nokia
pushed a commit
that referenced
this pull request
Apr 17, 2026
…net#25643) * [build] Add build timing report and dependency analysis tools Add three scripts for build performance instrumentation: - scripts/build-timing-report.sh: Parse per-package timing from build logs (HEADER/FOOTER timestamps), generate sorted duration table, phase breakdown, parallelism timeline, and CSV export. - scripts/build-dep-graph.py: Parse rules/*.mk dependency graph, compute critical path, fan-out/fan-in bottleneck analysis, and generate DOT/JSON output for visualization. - scripts/build-resource-monitor.sh: Sample CPU, memory, disk I/O, and Docker container count during builds for resource utilization analysis. Add "make build-report" target to slave.mk that runs the timing report and dependency analysis after a build completes. Example output from a VS build on 24-core/30GB machine: - 210 packages built in 53m wall time (173m CPU) - Max concurrency: 5 (with SONIC_CONFIG_BUILD_JOBS=4) - Critical path: 14 packages deep (libnl -> libswsscommon -> utilities) - Top bottleneck: LIBSWSSCOMMON with 48 downstream dependents Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> * Address Copilot review: fix 17 bugs in build analysis scripts - Use free -m with division instead of free -g to avoid rounding (#1) - Add = and ?= to Makefile dependency regex patterns (#2, sonic-net#7) - CPU calculation now uses /proc/stat delta (two reads) (#3, sonic-net#14) - Fix misleading 'critical path estimate' comment (sonic-net#4) - Fix parallelism timeline comment (60s not 10s) (sonic-net#5) - Include after-relationship packages in fan stats (sonic-net#6) - Guard disk I/O division by zero when INTERVAL<=1 (sonic-net#8) - Remove unused elapsed_line variable (sonic-net#9) - Remove redundant LIBSWSSCOMMON_DBG check (sonic-net#10) - Remove active_make_jobs from CSV header comment (sonic-net#11) - Wire up _RDEPENDS parsing to build reverse deps (sonic-net#12) - Remove unnecessary 'if v' filter on rdeps JSON (sonic-net#13) - Remove unused REPORT_FORMAT parameter (sonic-net#15) - Add cycle detection to critical path algorithm (sonic-net#16) - Add execute permission check for companion scripts (sonic-net#17) Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> --------- Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Co-authored-by: Rustiqly <rustiqly@users.noreply.github.com>
vganesan-nokia
pushed a commit
that referenced
this pull request
Apr 17, 2026
…dating udevd rules (sonic-net#26343) - Why I did it On SONiC SmartSwitch platforms with DPUs, systemd-udevd crashes with SIGABRT on every reboot when DPU firmware initialization is slow. During the initramfs boot phase, a standalone systemd-udevd daemon is started to handle device discovery. If DPU firmware takes longer than the 60-second udevadm settle timeout (BlueField-3 DPUs can take 120 seconds each in the failure case when they are stuck), the initramfs cannot stop this udevd before switch_root. The stale process survives into the real system but is never chrooted into the overlayfs root, leaving it with a broken filesystem view. When dpu-udev-manager.sh writes udev rules, the stale udevd detects the change and crashes on an assertion in systemd's chase() path resolution (assert(path_is_absolute(p)) at chase.c:648), because dir_fd_is_root() returns false for a process whose root still points to the initramfs rootfs rather than the overlayfs. This triggers a systemd issue : systemd/systemd#29559 which maintainers doesn't consider as a bug from systemd side. Raising this fix for our usecase. Core was generated by `/usr/lib/systemd/systemd-udevd --daemon --resolve-names=never'. Program terminated with signal SIGABRT, Aborted. #0 0x00007f29fe7f695c in ?? () from /lib/x86_64-linux-gnu/libc.so.6 (gdb) bt #0 0x00007f29fe7f695c in ?? () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x00007f29fe7a1cc2 in raise () from /lib/x86_64-linux-gnu/libc.so.6 #2 0x00007f29fe78a4ac in abort () from /lib/x86_64-linux-gnu/libc.so.6 #3 0x00007f29fea50c11 in ?? () from /usr/lib/x86_64-linux-gnu/systemd/libsystemd-shared-257.so sonic-net#4 0x00007f29feb94a8b in chase () from /usr/lib/x86_64-linux-gnu/systemd/libsystemd-shared-257.so sonic-net#5 0x00007f29feb956e2 in chase_and_opendir () from /usr/lib/x86_64-linux-gnu/systemd/libsystemd-shared-257.so sonic-net#6 0x00007f29feb9a609 in conf_files_list_strv () from /usr/lib/x86_64-linux-gnu/systemd/libsystemd-shared-257.so sonic-net#7 0x00007f29fea913e8 in config_get_stats_by_path () from /usr/lib/x86_64-linux-gnu/systemd/libsystemd-shared-257.so sonic-net#8 0x0000559f295519cf in ?? () sonic-net#9 0x0000559f29553a77 in ?? () sonic-net#10 0x00007f29fec36055 in ?? () from /usr/lib/x86_64-linux-gnu/systemd/libsystemd-shared-257.so sonic-net#11 0x00007f29fec3668d in sd_event_dispatch () from /usr/lib/x86_64-linux-gnu/systemd/libsystemd-shared-257.so sonic-net#12 0x00007f29fec394a8 in sd_event_run () from /usr/lib/x86_64-linux-gnu/systemd/libsystemd-shared-257.so sonic-net#13 0x00007f29fec396c7 in sd_event_loop () from /usr/lib/x86_64-linux-gnu/systemd/libsystemd-shared-257.so sonic-net#14 0x0000559f29545820 in ?? () sonic-net#15 0x00007f29fe78bca8 in ?? () from /lib/x86_64-linux-gnu/libc.so.6 sonic-net#16 0x00007f29fe78bd65 in __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6 sonic-net#17 0x0000559f29545c51 in ?? () - How I did it Added a kill_stale_udevd() function to dpu-udev-manager.sh that runs before writing the udev rules. It identifies the systemd-managed udevd PID via systemctl show, then kills any other systemd-udevd --daemon process that doesn't match -- these are leftover initramfs instances. If no stale process exists (e.g. DPUs are healthy and the initramfs udevd exited cleanly), the function is a no-op. - How to verify it Deploy the image on a SmartSwitch with DPUs in a state where firmware initialization times out (>60s per DPU) by stopping image installation before firmware install step Reboot the switch Verify no new systemd-udevd coredumps in /var/core/ Verify the stale process was killed: journalctl -b 0 | grep dpu-udev-manager should show killing stale initramfs udevd PID (systemd udevd is PID ) Verify systemd-udevd.service is healthy: systemctl status systemd-udevd should show active (running) Verify DPU udev rules were written: cat /etc/udev/rules.d/92-midplane-intf.rules should contain the DPU interface naming rules Signed-off-by: Hemanth Kumar Tirupati <tirupatihemanthkumar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vedganes vedavinayagam.ganesan@nokia.com
Changes for setting platfrom specific lag id boundary id in the chassis
app db. The platfrom specific lag id boundaries are supplied via
chassisdb.conf. The lag_id_start and lag_id_end boundary values sourced
from this file are set in chassis app db which will be used by lag id
allocator to allocate unique lag id in atomic fashion