Remove pipe users, add lmtp, bugfixes#316
Open
runout-at wants to merge 4 commits into
Open
Conversation
remove router for pipe user functionality introduce LMTP support bug fix: using local_part_suffixes enables possibility to use user-"something" localparts which could cause you trouble if you're creating email-adresses with dashes in between.
Add LMTP transport
Collaborator
|
Do the three parts in the subject really have to go together in the same PR? |
change the default to not use LMTP
Contributor
Author
not really. but it would be lots of work to separate it. I did just copy my running router config. |
Contributor
Author
|
I did think about splitting this PR but the change for LMTP would need to split out the pipe router from virtual_delivery anyways and and the review work would be more. The bugfixes are really small. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't change PR #247 anymore. Thats why I offer a new PR.
This PR would introduce the LMTP transport which is also in PR #307. The difference is that this version let you define in
lismacrodefsif you would like to use a socket or a command:Fallback is a normal delivery if no LMTP SOCKET/COMMAND is defined.
This PR removes pipe user functionality as discussed in PR #300 from the exim router. It seems we don't have the corresponding transport in our files.
I found and fixed a small bug which occurs in some special cases when using addresses with VEXIM_LOCALPART_SUFFIX.
In a query in the virtual_dom_groups router i fixed: use the email address instead of the username. As in veximpy the username might not be the address.
In
listmacrodefsI added(used in acl/50_exim4-config_check_mime - at least in my debian setup)