Add Doctype in each file, clean up index.php#236
Merged
Conversation
| session_start(); | ||
| header("Cache-control: private"); // IE6 hack to back forms + BACK button work | ||
| header("Content-Type: text/html; charset=utf-8"); | ||
| print '<!DOCTYPE html>'; |
Collaborator
There was a problem hiding this comment.
We have files which include httpheaders.php, but issue further header() calls. If you want this doctype, you should add it before the <html> tag to the files that have that tag.
Collaborator
Author
|
A bit of shell scripting later ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put
<!DOCTYPE html>to each file.index.php:
autofocusoption on first field instead of inline-javascript (localpart field doesn't exist anymore Use only username to login like it is used for all other authenticati… #110)