Skip to content

Always allow siteadmin to login#114

Merged
rimas-kudelis merged 1 commit into
vexim:masterfrom
Udera:siteadmin
Feb 22, 2016
Merged

Always allow siteadmin to login#114
rimas-kudelis merged 1 commit into
vexim:masterfrom
Udera:siteadmin

Conversation

@Udera

@Udera Udera commented Feb 21, 2016

Copy link
Copy Markdown
Collaborator

userenabled is not queried in https://github.com/vexim/vexim2/blob/master/vexim/login.php#L17 so $row[userenabled] doesn't exist. We could add this to the SQL queries but it why should someone disable siteadmin? Via vexim, there is no way to do (or undo) this.

rimas-kudelis added a commit that referenced this pull request Feb 22, 2016
Always allow siteadmin to login
@rimas-kudelis rimas-kudelis merged commit e3a27d1 into vexim:master Feb 22, 2016
@rimas-kudelis

Copy link
Copy Markdown
Collaborator

@Udera: I've merged this in, but you should update #110 to run the check for the username field, not localpart.

@rimas-kudelis rimas-kudelis added this to the Version 2.3 milestone Feb 22, 2016
@Udera Udera deleted the siteadmin branch February 22, 2016 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants