Fix groups receipts#107
Merged
Merged
Conversation
| g.name = '${quote_mysql:$local_part}'}}} \ | ||
| {$sender_address} \ | ||
| {${lookup mysql{select u.username \ | ||
| {${lookup mysql{select concat_ws('@', localpart, d.domain) \ |
Collaborator
There was a problem hiding this comment.
please use u.localpart instead of just localpart where SELECTs use data from multiple tables.
rimas-kudelis
added a commit
that referenced
this pull request
Feb 9, 2016
Prepare groups for non-email-address usernames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are using a user table where the username of each user is not their e-mail address (for example #106), groups won't work because provided exim configuration resolves group addresses to the usernames of their members, instead of their e-mail addresses. This works when their usernames are their e-mail addresses, but will fail otherwise.
This patch also fixes forms that assume that username = e-mail address to correctly show e-mail addresses.