π‘οΈ Sentinel: [MEDIUM] Fix Information Leakage via Error Messages#48
π‘οΈ Sentinel: [MEDIUM] Fix Information Leakage via Error Messages#48DerUntote wants to merge 1 commit into
Conversation
Co-authored-by: DerUntote <8378077+DerUntote@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: Raw internal RPC and system error messages (e.g., from bitcoind-rpc client) were being sent directly to Discord users via
message.reply(err.message). This can potentially leak sensitive infrastructure information or internal system states.π― Impact: An attacker or user could glean insights into internal daemon operations, connection errors, or server details by intentionally triggering failed transactions or operations and observing the error text.
π§ Fix: Modified all tipper modules in
bot/modules/to catch these errors, log them internally usingconsole.error(err), and instead reply to the user with a safe, generic message (An internal error occurred.). I also appended.catch(console.error)to the message delete promises to prevent unhandled promise rejections if deleting the message fails (e.g., due to permissions).β Verification: Ran
node -con all modified files to ensure syntax validity, followed bynpm run precommitfor code formatting. I successfully verified the code structure via diff review. No regressions are expected as normal successful flows remain completely unaffected.PR created automatically by Jules for task 9538634825032103516 started by @DerUntote