π‘οΈ Sentinel: [CRITICAL] Fix RPC Error Information Leakage#47
π‘οΈ Sentinel: [CRITICAL] Fix RPC Error Information Leakage#47DerUntote wants to merge 1 commit into
Conversation
Co-authored-by: DerUntote <8378077+DerUntote@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Information Disclosure. The bot was directly returning unhandled
err.messagefrombitcoind-rpcdaemon connections to Discord channels. This could leak internal architecture details, internal node connection strings, and server states to unauthorized users in public channels.π― Impact: An attacker could craft specific commands or wait for daemon timeouts to enumerate backend nodes and connection structures, providing a reconnaissance vector for further attacks against the infrastructure.
π§ Fix: Substituted raw
err.messageDiscord replies with a generic"An error occurred while processing your request."message. Addedconsole.error(err)to ensure developers can still trace and debug the underlying RPC failures via backend logs without exposing them publicly. Also added a chained.catch(() => {})on message deletion to prevent unhandled promise rejections on Discord API failures.β Verification: Code syntaxes verified successfully (
node -c). Codebase checked comprehensively to confirm all instances of this exact error leakage pattern withinbot/modules/*Tipper.jswere remediated. Formatting applied (npm run precommit).PR created automatically by Jules for task 2668860054511930399 started by @DerUntote